Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action with multi-CPU architecture support and multi docker file support. #5

Merged
merged 14 commits into from
Aug 3, 2020

Conversation

skabashnyuk
Copy link
Collaborator

@skabashnyuk skabashnyuk commented Jul 30, 2020

  • Build and push to docker registry Dockerfile under linux/amd64,linux/s390x,linux/arm64,linux/ppc64le
  • Build and push to docker registry rhel.Dockerfile under linux/amd64
  • Allow to configure with secrets DOCKER_USERNAME, DOCKER_PASSWORD, DOCKER_IMAGE, DOCKER_REPO
  • Same workflow for master and prs
  • Is able to push tags

Results https://quay.io/repository/skabashn/configbump?tab=tags

 - Build and push to docker registry Dockerfile under linux/amd64,linux/s390x
 - Build and push to docker registry rhel.Dockerfile under linux/amd64,linux/s390x
 - Allow to configure with secrets DOCKER_USERNAME, DOCKER_PASSWORD, DOCKER_IMAGE, DOCKER_REPO
 - Same workflow for master and prs
 - Is able to push tags
@skabashnyuk skabashnyuk changed the title Github action with muti-arch and multi docker file support. Github action with muti architectural and multi docker file support. Jul 30, 2020
@skabashnyuk skabashnyuk changed the title Github action with muti architectural and multi docker file support. Github action with multi-CPU architecture support and multi docker file support. Jul 30, 2020
@benoitf
Copy link

benoitf commented Jul 30, 2020

could we add arm64 and ppc64le ?

@skabashnyuk
Copy link
Collaborator Author

could we add arm64 and ppc64le ?

I don't see a big problem.
several thoughts:

  • take more time to build.
  • we need to ensure it's stable. I would say two architectures that repeatedly stable built - it's already a win.
  • we need to ensure all other images build on that architectures too. However, for this concrete case, it might be useful to build it unconditionally.

@skabashnyuk
Copy link
Collaborator Author

CC @nickboldt @vparfonov @ibuziuk

@benoitf
Copy link

benoitf commented Jul 30, 2020

more time to build:
--> it's not done in parallel ?

@benoitf
Copy link

benoitf commented Jul 30, 2020

we need to ensure all other images build on that architectures too. However, for this concrete case, it might be useful to build it unconditionally.

idea was to bring amd64, arm64 and the two from IBMs
Usually when it's starting to work with more than once arch it's little thing to adapt.

skabashnyuk and others added 4 commits July 31, 2020 07:39
Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>
Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>
@skabashnyuk
Copy link
Collaborator Author

@benoitf @sparkoo added linux/arm64,linux/ppc64le. Time of build increased from 12m->15m

@benoitf
Copy link

benoitf commented Jul 31, 2020

@skabashnyuk maybe you could spin Docker Buildx rhel with another job so it's done in parallel

@skabashnyuk
Copy link
Collaborator Author

@skabashnyuk maybe you could spin Docker Buildx rhel with another job so it's done in parallel

I'll experiment on that. At this moment I'm afraid errors during concurrent pushes. And logout probably has to be mode on another job too.

@skabashnyuk skabashnyuk merged commit 884b7c4 into che-incubator:master Aug 3, 2020
@skabashnyuk skabashnyuk deleted the civ3 branch August 3, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants