Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21325] Remove all code related to FAST CDR v1 #5073

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 16, 2024

Description

This PR removes all compiled conditioned code related to Fast CDR v1, as Fast DDS v3.0.0 will only support Fast CDR v2 (in fact Fast DDS CMakeLists.txt already requieres Fast CDR v2).

This PR is associated with the following Fast DDS Gen PR, which has been used to regenerated the different type supports:

Related PRs:

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch from ff2a001 to 948aca3 Compare July 20, 2024 05:24
@EduPonz EduPonz requested a review from richiware July 20, 2024 05:26
@richiware richiware force-pushed the feature/remove_fastcdrv1_code branch from 948aca3 to 79a0cea Compare July 23, 2024 08:32
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@richiware richiware force-pushed the feature/remove_fastcdrv1_code branch from 79a0cea to f7b2b9f Compare July 24, 2024 06:39
@richiware richiware requested review from richiware and removed request for richiware July 24, 2024 06:39
@EduPonz EduPonz requested a review from richiware July 24, 2024 07:02
@EduPonz EduPonz removed the request for review from richiware July 24, 2024 13:10
@EduPonz EduPonz merged commit 9e4f961 into master Jul 24, 2024
22 of 31 checks passed
@EduPonz EduPonz deleted the feature/remove_fastcdrv1_code branch July 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants