Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21325] Remove all code related to FAST CDR v1 #882

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[21325] Remove all code related to FAST CDR v1 #882

merged 3 commits into from
Jul 24, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 18, 2024 •
edited
Loading

Description

Fast DDS Docs counterpart of:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@EduPonz EduPonz added this to the v3.0.0 milestone Jul 18, 2024
@EduPonz EduPonz mentioned this pull request Jul 18, 2024
Merged
7 tasks
@EduPonz EduPonz requested a review from richiware July 20, 2024 05:26
richiware
richiware requested changes Jul 22, 2024
View reviewed changes
docs/conf.py Outdated Show resolved Hide resolved
@EduPonz
Refs #21325: fastcdr/config.h is generated with version 2
6086a26 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21325: Define FASTDDS_DOCS_BUILD when calling swig CLI
620bd30 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz
Refs #21325: Apply Ricardo's suggestion
b55f398 
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch from f9e41aa to b55f398 Compare July 24, 2024 07:02
@richiware richiware self-requested a review July 24, 2024 07:06
richiware
richiware previously approved these changes Jul 24, 2024
View reviewed changes
@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch from fd532d4 to f910e66 Compare July 24, 2024 10:18
@EduPonz
Copy link
Author

EduPonz commented Jul 24, 2024

A green RTD build with the correct branches here. Dropping the test commit and running CI

@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch from f910e66 to b55f398 Compare July 24, 2024 10:34
@EduPonz EduPonz merged commit f97bc61 into master Jul 24, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/remove_fastcdrv1_code branch July 24, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiware richiware richiware left review comments

Assignees
No one assigned
Labels
ci-pending
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @richiware @MiguelCompany