Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21325] Remove all code related to FAST CDR v1 #378

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jul 16, 2024

Description

The upcoming Fast DDS Gen v4.0.0 will generated code for Fast DDS v3.0, which requieres Fast CDR v2. For this reason, this PR removes all the compiled conditioned generated code relative to Fast CDR v1. This PR is the counterpart of:

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz EduPonz added this to the v4.0.0 milestone Jul 16, 2024
@EduPonz EduPonz requested a review from richiware July 16, 2024 12:44
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 16, 2024
@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch 2 times, most recently from fd07b09 to db6c94e Compare July 18, 2024 07:37
Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the feature/remove_fastcdrv1_code branch from db6c94e to 14c885b Compare July 18, 2024 12:49
@EduPonz EduPonz requested review from richiware and removed request for richiware July 18, 2024 12:58
@EduPonz EduPonz merged commit c3e3c73 into master Jul 24, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/remove_fastcdrv1_code branch July 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants