Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeater Implementation [14951] #249

Merged
merged 28 commits into from
Aug 8, 2022
Merged

Repeater Implementation [14951] #249

merged 28 commits into from
Aug 8, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jul 14, 2022

Tasks:

  • Implement Repeater in Core
  • Implement Repeater in RTPS DS Participant
  • Add unit tests
  • Change router validity to allow only 1 participant when repeater
  • Implement enhance and generic Pool
  • Update YAML validator
  • Validate on blackbox test (if it is possible to properly isolate publishers and subscribers)
  • Documentation
  • Release notes
  • Add Code documentation
  • Refactor documentation with new kind names

This PR requires a new API exposure in Fast DDS:
eProsima/Fast-DDS#2841

Over PR: #251

Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending review of tests and documentation.

docs/rst/examples/repeater_example.rst Outdated Show resolved Hide resolved
docs/rst/examples/repeater_example.rst Outdated Show resolved Hide resolved
docs/rst/examples/repeater_example.rst Show resolved Hide resolved
docs/rst/use_cases/repeater.rst Outdated Show resolved Hide resolved
jparisu added 16 commits August 2, 2022 13:52
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov August 2, 2022 12:00 Inactive
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov August 2, 2022 12:00 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov August 8, 2022 07:11 Inactive
@jparisu jparisu temporarily deployed to codecov August 8, 2022 07:11 Inactive
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov August 8, 2022 07:32 Inactive
@jparisu jparisu temporarily deployed to codecov August 8, 2022 07:32 Inactive
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, documentation update and tests in different PR

@jparisu jparisu merged commit 2c49682 into main Aug 8, 2022
@jparisu jparisu deleted the feature/repeater branch August 8, 2022 10:44
@jparisu jparisu mentioned this pull request Aug 8, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants