Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to createRTPSWriter with a custom change pool [14951] #2841

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Add API to createRTPSWriter with a custom change pool [14951] #2841

merged 4 commits into from
Jul 29, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jul 14, 2022

Signed-off-by: jparisu javierparis@eprosima.com

Some API is missing in order to create a RTPSWriter with a custom ChangePool

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@jparisu jparisu mentioned this pull request Jul 14, 2022
Merged
11 tasks
juanlofer-eprosima
juanlofer-eprosima requested changes Jul 18, 2022
View reviewed changes
include/fastdds/rtps/RTPSDomain.h Show resolved Hide resolved
src/cpp/rtps/RTPSDomain.cpp Outdated Show resolved Hide resolved
juanlofer-eprosima
juanlofer-eprosima previously approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15
Copy link
Contributor

@richiprosima Please test this

@rsanchez15 rsanchez15 added this to the v2.8.0 milestone Jul 20, 2022
jparisu added 2 commits July 29, 2022 07:27
Add API to createRTPSWriter with a custom change pool
6d1c1bf 
Signed-off-by: jparisu <javierparis@eprosima.com>
apply suggestions
ffa1ceb 
Signed-off-by: jparisu <javierparis@eprosima.com>
extend API to entity Id
053d769 
Signed-off-by: jparisu <javierparis@eprosima.com>
MiguelCompany
MiguelCompany requested changes Jul 29, 2022
View reviewed changes
src/cpp/rtps/RTPSDomain.cpp Outdated Show resolved Hide resolved
apply suggestion
be4dd02 
Signed-off-by: jparisu <javierparis@eprosima.com>
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Jul 29, 2022
@MiguelCompany
Copy link
Member

@richiprosima Please test this

MiguelCompany
MiguelCompany approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we will need a follow-up PR adding tests for the new APIs

@MiguelCompany MiguelCompany merged commit 4d35a6b into master Jul 29, 2022
@MiguelCompany MiguelCompany deleted the feature/change-pool-api branch July 29, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@juanlofer-eprosima juanlofer-eprosima juanlofer-eprosima left review comments

Assignees
No one assigned
Labels
high-priority no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jparisu @rsanchez15 @MiguelCompany @juanlofer-eprosima