Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial peers [15191] #251

Closed
wants to merge 8 commits into from
Closed

Initial peers [15191] #251

wants to merge 8 commits into from

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Jul 19, 2022

Tasks:

  • Implement Initial Peers Participant
  • Add blackbox tests
  • Update YAML and YAML validator
  • Exhaustive testing
  • Documentation
  • Release notes
  • Add Code documentation
  • Do not create multicast by default in Fast DDS

Over PR: #250

jparisu added 7 commits July 19, 2022 09:25
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov July 19, 2022 15:21 Inactive
@jparisu jparisu temporarily deployed to codecov July 19, 2022 15:21 Inactive
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #251 (80bca68) into main (99ea607) will decrease coverage by 0.37%.
The diff coverage is 48.55%.

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
- Coverage   59.34%   58.97%   -0.38%     
==========================================
  Files          91       93       +2     
  Lines        3200     3244      +44     
  Branches     1188     1227      +39     
==========================================
+ Hits         1899     1913      +14     
- Misses        574      578       +4     
- Partials      727      753      +26     
Impacted Files Coverage Δ
...outer_core/types/security/tls/TlsConfiguration.hpp 100.00% <ø> (ø)
...cpp/configuration/DDSRouterReloadConfiguration.cpp 20.68% <ø> (-13.60%) ⬇️
...iguration/participant/ParticipantConfiguration.cpp 38.46% <0.00%> (-14.48%) ⬇️
...ion/participant/SimpleParticipantConfiguration.cpp 35.71% <ø> (-8.04%) ⬇️
...er_yaml/include/ddsrouter_yaml/impl/YamlReader.ipp 63.41% <ø> (ø)
...e/src/cpp/configuration/DDSRouterConfiguration.cpp 48.14% <20.00%> (-14.90%) ⬇️
...entations/rtps/impl/DiscoveryServerParticipant.ipp 44.85% <25.00%> (-3.03%) ⬇️
ddsrouter_core/src/cpp/core/ParticipantFactory.cpp 52.08% <29.41%> (+2.08%) ⬆️
...rticipant/InitialPeersParticipantConfiguration.cpp 31.03% <31.03%> (ø)
ddsrouter_core/src/cpp/core/DDSRouterImpl.cpp 45.00% <33.33%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ea607...80bca68. Read the comment docs.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov July 19, 2022 20:13 Inactive
@jparisu jparisu temporarily deployed to codecov July 19, 2022 20:13 Inactive
@jparisu jparisu mentioned this pull request Jul 20, 2022
11 tasks
@jparisu
Copy link
Contributor Author

jparisu commented Aug 8, 2022

Closed in favor to #249

@jparisu jparisu closed this Aug 8, 2022
@rsanchez15 rsanchez15 deleted the feature/initial-peers branch January 3, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant