Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): Win architecture & tests #238

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Conversation

prokopsimek
Copy link
Member

@prokopsimek prokopsimek commented Feb 3, 2020

Description

Fix all tests and init function for Windows architecture. We expect no failure in the Windows pipeline since now.

Motivation and Context

we want to support Windows

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have added new practice to practice list in README.md.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek
Copy link
Member Author

prokopsimek commented Feb 3, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
commander ^4.1.1 ^4.1.0
@types/node 13.7.0 12.12.26

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
bitbucket 2.0.0 1.17.1
@semantic-release/changelog 5.0.0 3.0.6
@semantic-release/git 9.0.0 8.0.0
@types/node 13.7.0 12.12.26
semantic-release 17.0.2 16.0.4
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/


Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@codecov-io
Copy link

Codecov Report

Merging #238 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #238   +/-   ##
======================================
  Coverage    90.2%   90.2%           
======================================
  Files         169     169           
  Lines        3676    3676           
  Branches      599     599           
======================================
  Hits         3316    3316           
  Misses        360     360
Impacted Files Coverage Δ
src/scanner/Scanner.ts 87.82% <100%> (ø) ⬆️

@prokopsimek prokopsimek marked this pull request as ready for review February 3, 2020 17:54
@prokopsimek prokopsimek self-assigned this Feb 3, 2020
@adelkahomolova adelkahomolova merged commit 0d3fbe1 into master Feb 4, 2020
@adelkahomolova adelkahomolova deleted the fix/win32-arch branch February 4, 2020 09:23
prokopsimek pushed a commit that referenced this pull request Feb 4, 2020
## [2.0.5](v2.0.4...v2.0.5) (2020-02-04)

### Bug Fixes

* **init:** Win architecture & tests ([2d1aea6](2d1aea6))
* **init:** Win architecture & tests ([#238](#238)) ([0d3fbe1](0d3fbe1))
* **services:** deprecation notice removed ([b494c01](b494c01))
* **services:** deprecation notice removed ([#239](#239)) ([d759beb](d759beb))
@prokopsimek
Copy link
Member Author

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants