Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjusting practices & inspector for gradle/kotlin variation #243

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

ryzzaki
Copy link
Contributor

@ryzzaki ryzzaki commented Feb 10, 2020

Description

This PR will fix the current Java practices and Inspector to accommodate for the Kotlin/Gradle variation involving build.gradle.kts.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have added new practice to practice list in README.md.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek
Copy link
Member

prokopsimek commented Feb 10, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
bitbucket 2.0.3 2.0.2
memfs 3.0.6 3.0.4
semver 7.1.3 7.1.2
@typescript-eslint/eslint-plugin 2.19.2 2.19.0
@typescript-eslint/parser 2.19.2 2.19.0
semantic-release 17.0.3 17.0.2
update-notifier 4.1.0 4.0.0
@types/node 13.7.1 12.12.26
nock 11.8.2 11.7.2

Impact changed from high to medium.

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
fix(init): Win architecture & tests (#238) subject must not be sentence-case, start-case, pascal-case, upper-case
                                        |                                                                        

fix(init): Win architecture & tests |

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@types/node 13.7.1 12.12.26
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/


Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@ryzzaki ryzzaki marked this pull request as ready for review February 22, 2020 12:12
@prokopsimek prokopsimek merged commit f702641 into master Feb 25, 2020
@prokopsimek prokopsimek deleted the java/adjusting_gradle_kts branch February 25, 2020 08:11
@prokopsimek
Copy link
Member

🎉 This PR is included in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants