Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint all and remove unnecessary imports #245

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

prokopsimek
Copy link
Member

Description

  • lint all and remove unnecessary imports and nocks

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have added new practice to practice list in README.md.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prokopsimek prokopsimek self-assigned this Feb 11, 2020
@prokopsimek prokopsimek force-pushed the feature/catch-pending-nocks branch from 7630d37 to d61fe6a Compare February 11, 2020 09:59
@prokopsimek
Copy link
Member Author

prokopsimek commented Feb 11, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Break down large pull requests into smaller ones

Large pull request are hard to code review and it reduces the probability of finding bugs. Split your PRs into logical units. Do not have PR with more than 1000 changes. https://medium.com/@hugooodias/the-anatomy-of-a-perfect-pull-request-567382bb6067

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
bitbucket 2.0.2 1.17.1
@typescript-eslint/eslint-plugin 2.19.2 2.19.0
@typescript-eslint/parser 2.19.2 2.19.0
@types/node 13.7.0 12.12.26
nock 11.8.2 11.7.2

Impact changed from high to medium.

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
fix(init): Win architecture & tests (#238) subject must not be sentence-case, start-case, pascal-case, upper-case
                                        |                                                                        

fix(init): Win architecture & tests |
fix(init): Win architecture & tests | subject must not be sentence-case, start-case, pascal-case, upper-case

Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
bitbucket 2.0.2 1.17.1
@semantic-release/changelog 5.0.0 3.0.6
@semantic-release/git 9.0.0 8.0.0
@types/node 13.7.0 12.12.26
semantic-release 17.0.2 16.0.4
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/


Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #245 into master will decrease coverage by 3.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   90.27%   87.16%   -3.11%     
==========================================
  Files         170      170              
  Lines        3701     3701              
  Branches      604      604              
==========================================
- Hits         3341     3226     -115     
- Misses        360      475     +115
Impacted Files Coverage Δ
src/practices/index.ts 100% <ø> (ø) ⬆️
src/services/git/VCSServicesUtils.ts 75% <ø> (ø) ⬆️
src/test/helpers/bitbucketNock.ts 100% <ø> (ø) ⬆️
src/scanner/Scanner.ts 32.05% <0%> (-55.77%) ⬇️
src/contexts/language/LanguageContext.ts 86.95% <0%> (-13.05%) ⬇️
src/services/git/Git.ts 86.2% <0%> (-8.05%) ⬇️
src/contexts/scanner/scannerContextBinding.ts 85% <0%> (-7.5%) ⬇️
.../practices/LanguageIndependent/DoesPullRequests.ts 92.59% <0%> (-7.41%) ⬇️
src/reporters/ReporterUtils.ts 82.75% <0%> (-6.9%) ⬇️
...ractices/JavaScript/ESLintWithoutErrorsPractice.ts 72.34% <0%> (-6.39%) ⬇️
... and 5 more

@prokopsimek prokopsimek merged commit 259480b into master Feb 11, 2020
@prokopsimek prokopsimek deleted the feature/catch-pending-nocks branch February 11, 2020 10:35
@prokopsimek
Copy link
Member Author

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants