-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint all and remove unnecessary imports #245
Conversation
7630d37
to
d61fe6a
Compare
DX Scanner Reporthttps://github.com/DXHeroes/dx-scanner
|
Name | New | Current |
---|---|---|
bitbucket | 2.0.2 | 1.17.1 |
@typescript-eslint/eslint-plugin | 2.19.2 | 2.19.0 |
@typescript-eslint/parser | 2.19.2 | 2.19.0 |
@types/node | 13.7.0 | 12.12.26 |
nock | 11.8.2 | 11.7.2 |
Impact changed from high to medium.
🔔 Improvements with minor impact
Write Commit Messages by Convention
https://www.conventionalcommits.org/
Commit Message | Problems |
---|---|
fix(init): Win architecture & tests (#238) | subject must not be sentence-case, start-case, pascal-case, upper-case |
|
fix(init): Win architecture & tests |
fix(init): Win architecture & tests | subject must not be sentence-case, start-case, pascal-case, upper-case
Update Dependencies of Major Level
Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates
Name | New | Current |
---|---|---|
bitbucket | 2.0.2 | 1.17.1 |
@semantic-release/changelog | 5.0.0 | 3.0.6 |
@semantic-release/git | 9.0.0 | 8.0.0 |
@types/node | 13.7.0 | 12.12.26 |
semantic-release | 17.0.2 | 16.0.4 |
Use a JS Logging Library
Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/
Implementation is not adoption.
We can help you with both. :-)
dxheroes.io
Found a bug? Please report.
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 90.27% 87.16% -3.11%
==========================================
Files 170 170
Lines 3701 3701
Branches 604 604
==========================================
- Hits 3341 3226 -115
- Misses 360 475 +115
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Motivation and Context
Types of changes
Checklist: