chore: lint all and remove unnecessary imports

jest.config.js

@@ -114,7 +114,7 @@ module.exports = {
   setupFiles: ['./src/jest.setup.ts'],
 
   // A list of paths to modules that run some code to configure or set up the testing framework before each test
-  // setupFilesAfterEnv: [],
+  setupFilesAfterEnv: ['./src/test/jest.setupFileAfterEnv.ts'],
 
   // A list of paths to snapshot serializer modules Jest should use for snapshot testing
   // snapshotSerializers: [],

src/detectors/ScanningStrategyDetector.spec.ts

@@ -1,4 +1,3 @@
-import nock from 'nock';
 import git from 'simple-git/promise';
 import { createTestContainer } from '../inversify.config';
 import { GitHubNock } from '../test/helpers/gitHubNock';
@@ -8,10 +7,6 @@ jest.mock('simple-git/promise');
 describe('ScanningStrategyDetector', () => {
   const mockedGit = <jest.Mock>git;
 
-  beforeEach(() => {
-    nock.cleanAll();
-  });
-
   describe('#detect', () => {
     it('local path without remote', async () => {
       mockedGit.mockImplementation(() => {

src/inspectors/CollaborationInspector.spec.ts

@@ -1,5 +1,4 @@
 import { CollaborationInspector } from './CollaborationInspector';
-import nock from 'nock';
 import { TestContainerContext } from '../inversify.config';
 import { createTestContainer } from '../inversify.config';
 import { GitHubNock } from '../test/helpers/gitHubNock';
@@ -29,7 +28,6 @@ describe('Collaboration Inspector', () => {
 
   beforeEach(async () => {
     inspector = <CollaborationInspector>containerCtx.practiceContext.collaborationInspector;
-    nock.cleanAll();
   });
 
   it('returns paginated pull requests', async () => {

src/inspectors/IssueTrackingInspector.spec.ts

@@ -1,5 +1,4 @@
 import { IssueTrackingInspector } from './IssueTrackingInspector';
-import nock from 'nock';
 import { TestContainerContext, createTestContainer } from '../inversify.config';
 import { GitHubNock } from '../test/helpers/gitHubNock';
 import {
@@ -20,10 +19,6 @@ describe('Issue Tracking Inspector', () => {
     inspector = <IssueTrackingInspector>containerCtx.practiceContext.issueTrackingInspector;
   });
 
-  beforeEach(() => {
-    nock.cleanAll();
-  });
-
   it('returns paginated issues', async () => {
     new GitHubNock('1', 'octocat', 1, 'Hello-World').getIssues().reply(200, getIssuesResponse);
     const response = await inspector.listIssues('octocat', 'Hello-World');

src/lib/assertNever.spec.ts

@@ -1,7 +1,4 @@
 import { assertNever } from './assertNever';
-import { ProgrammingLanguage, PracticeImpact } from '../model';
-import { PracticeDetail } from '../practices/IPractice';
-import { ReportDetailType, ReporterData } from '../reporters/ReporterData';
 
 describe('AssertNever', () => {
   it('Throws error if it is called', () => {

src/practices/LanguageIndependent/CorrectCommitMessagesPractice.spec.ts

@@ -1,4 +1,3 @@
-import nock from 'nock';
 import { CollaborationInspector } from '../../inspectors/CollaborationInspector';
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
@@ -14,10 +13,6 @@ describe('CorrectCommitMessagesPractice', () => {
   const MockedCollaborationInspector = <jest.Mock<CollaborationInspector>>(<unknown>CollaborationInspector);
   let mockCollaborationInspector: CollaborationInspector;
 
-  beforeEach(async () => {
-    nock.cleanAll();
-  });
-
   beforeAll(() => {
     containerCtx = createTestContainer();
     containerCtx.container.bind('CorrectCommitMessagesPractice').to(CorrectCommitMessagesPractice);

src/practices/LanguageIndependent/DoesPullRequests.spec.ts

@@ -1,7 +1,6 @@
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
 import { DoesPullRequestsPractice } from './DoesPullRequests';
-import nock from 'nock';
 import { GitHubNock } from '../../test/helpers/gitHubNock';
 import { getRepoCommitsResponse } from '../../services/git/__MOCKS__/gitHubServiceMockFolder/getRepoCommitsResponse.mock';
 import { PullRequestState } from '../../inspectors/ICollaborationInspector';
@@ -10,10 +9,6 @@ describe('DoesPullRequests', () => {
   let practice: DoesPullRequestsPractice;
   let containerCtx: TestContainerContext;
 
-  beforeEach(async () => {
-    nock.cleanAll();
-  });
-
   beforeAll(() => {
     containerCtx = createTestContainer();
     containerCtx.container.bind('DoesPullRequests').to(DoesPullRequestsPractice);

src/practices/LanguageIndependent/ThinPullRequestsPractice.spec.ts

@@ -1,4 +1,3 @@
-import nock from 'nock';
 import { CollaborationInspector } from '../../inspectors';
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
@@ -8,18 +7,13 @@ import { ThinPullRequestsPractice } from './ThinPullRequestsPractice';
 import { getPullRequestsResponse } from '../../services/git/__MOCKS__/bitbucketServiceMockFolder/getPullRequestsResponse';
 import moment from 'moment';
 import { getPullRequestResponse } from '../../services/git/__MOCKS__/bitbucketServiceMockFolder';
-import _ from 'lodash';
 
 describe('ThinPullRequestsPractice', () => {
   let practice: ThinPullRequestsPractice;
   let containerCtx: TestContainerContext;
   const MockedCollaborationInspector = <jest.Mock<CollaborationInspector>>(<unknown>CollaborationInspector);
   let mockCollaborationInspector: CollaborationInspector;
 
-  beforeEach(async () => {
-    nock.cleanAll();
-  });
-
   beforeAll(() => {
     containerCtx = createTestContainer();
     containerCtx.container.bind('ThinPullRequestsPractice').to(ThinPullRequestsPractice);

src/practices/LanguageIndependent/TimeToSolveIssuesPractice.spec.ts

@@ -1,5 +1,4 @@
 import moment from 'moment';
-import nock from 'nock';
 import { IssueTrackingInspector } from '../../inspectors';
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
@@ -16,10 +15,6 @@ describe('TimeToSolveIssuesPractice', () => {
   const MockedIssueTrackingInspector = <jest.Mock<IssueTrackingInspector>>(<unknown>IssueTrackingInspector);
   let mockIssueTrackingInspector: IssueTrackingInspector;
 
-  beforeEach(async () => {
-    nock.cleanAll();
-  });
-
   beforeAll(() => {
     containerCtx = createTestContainer();
     containerCtx.container.bind('TimeToSolveIssuesPractice').to(TimeToSolveIssuesPractice);

src/practices/LanguageIndependent/TimeToSolvePullRequestsPractice.spec.ts

@@ -1,5 +1,4 @@
 import moment from 'moment';
-import nock from 'nock';
 import { CollaborationInspector } from '../../inspectors';
 import { createTestContainer, TestContainerContext } from '../../inversify.config';
 import { PracticeEvaluationResult } from '../../model';
@@ -16,10 +15,6 @@ describe('TimeToSolvePullRequestsPractice', () => {
   const MockedCollaborationInspector = <jest.Mock<CollaborationInspector>>(<unknown>CollaborationInspector);
   let mockCollaborationInspector: CollaborationInspector;
 
-  beforeEach(async () => {
-    nock.cleanAll();
-  });
-
   beforeAll(() => {
     containerCtx = createTestContainer();
     containerCtx.container.bind('TimeToSolvePractice').to(TimeToSolvePullRequestsPractice);

src/practices/index.ts

@@ -29,7 +29,6 @@ import { TimeToSolvePullRequestsPractice } from './LanguageIndependent/TimeToSol
 import { TimeToSolveIssuesPractice } from './LanguageIndependent/TimeToSolveIssuesPractice';
 import { ThinPullRequestsPractice } from './LanguageIndependent/ThinPullRequestsPractice';
 import { SecurityVulnerabilitiesPractice } from './JavaScript/SecurityVulnerabilitiesPractice';
-import { FirstTestPractice, SecondTestPractice, InvalidTestPractice } from '../scanner';
 import { JavaPackageManagementUsedPractice } from './Java/JavaPackageManagementUsedPractice';
 import { JavaLoggerUsedPractice } from './Java/JavaLoggerUsedPractice';
 import { JavaTestingFrameworkUsedPractice } from './Java/JavaTestingFrameworkUsedPractice';

src/services/bitbucket/BitbucketService.spec.ts

@@ -1,4 +1,3 @@
-import nock from 'nock';
 import { PullRequestState, IssueState } from '../../inspectors';
 import {
   getIssueResponse,
@@ -24,7 +23,7 @@ describe('Bitbucket Service', () => {
 
   beforeEach(async () => {
     service = new BitbucketService(argumentsProviderFactory({ uri: '.' }));
-    nock.cleanAll();
+
     bitbucketNock = new BitbucketNock('pypy', 'pypy');
   });
 
@@ -131,7 +130,6 @@ describe('Bitbucket Service', () => {
 
   it('returns open issues in own interface', async () => {
     const mockIssue = bitbucketIssueResponseFactory({ state: BitbucketIssueState.new });
-    bitbucketNock.getOwnerId();
     bitbucketNock.listIssuesResponse([mockIssue], { filter: { state: BitbucketIssueState.new } });
 
     const response = await service.listIssues('pypy', 'pypy', { filter: { state: IssueState.open } });

src/services/git/Git.spec.ts

@@ -1,6 +1,5 @@
 import { Git } from './Git';
 import { GitHubNock } from '../../test/helpers/gitHubNock';
-import nock from 'nock';
 import { GitHubService } from './GitHubService';
 import { argumentsProviderFactory } from '../../test/factories/ArgumentsProviderFactory';
 
@@ -15,7 +14,6 @@ describe('Git', () => {
 
   beforeEach(() => {
     service.purgeCache();
-    nock.cleanAll();
   });
 
   describe('#exists', () => {
@@ -240,8 +238,6 @@ describe('Git', () => {
     it('stops on false', async () => {
       gitHubNock.getDirectory('mockFolder', ['mockFile.ts'], ['mockSubFolder']);
       gitHubNock.getFile('mockFolder/mockFile.ts');
-      gitHubNock.getDirectory('mockFolder/mockSubFolder', ['mockSubFolderFile.txt'], []);
-      gitHubNock.getFile('mockFolder/mockSubFolder/mockSubFolderFile.txt');
 
       const files: string[] = [];
 

src/services/git/GitHubService.spec.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/camelcase */
-import nock from 'nock';
 import { GitHubService } from './GitHubService';
 import { GitHubNock } from '../../test/helpers/gitHubNock';
 import {
@@ -34,7 +33,6 @@ describe('GitHub Service', () => {
 
   beforeEach(async () => {
     service = new GitHubService(argumentsProviderFactory({ uri: '.' }));
-    nock.cleanAll();
   });
 
   describe('#getPullRequests', () => {

src/services/git/VCSServicesUtils.ts

@@ -1,5 +1,4 @@
 import { PullRequestState } from '../../inspectors/ICollaborationInspector';
-import { VCSServiceType } from './IVCSService';
 import { GitHubIssueState } from './IGitHubService';
 import { IssueState } from '../../inspectors';
 import { BitbucketIssueState, BitbucketPullRequestState } from '../bitbucket/IBitbucketService';

src/test/helpers/bitbucketNock.ts

@@ -7,8 +7,6 @@ import { bitbucketListPRsResponseFactory } from '../factories/responses/bitbucke
 import { bitbucketListPullCommitsResponseFactory } from '../factories/responses/bitbucket/listPullCommitsResponseFactory';
 import { bitbucketListCommitResponseFactory } from '../factories/responses/bitbucket/listRepoCommitsResponseFactory';
 import { BitbucketPullRequestState, BitbucketIssueState } from '../../services/bitbucket/IBitbucketService';
-import _ from 'lodash';
-import qs from 'qs';
 import { VCSServicesUtils } from '../../services/git/VCSServicesUtils';
 
 export class BitbucketNock {

src/test/jest.setupFileAfterEnv.ts

@@ -0,0 +1,5 @@
+import nock from 'nock';
+
+beforeEach(() => {
+  nock.cleanAll();
+});