Deprecate Future.{eta_min,eta_max}
#468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying feature has already been removed from SAPI, but let's provide a grace period for Ocean users. Although the return value has been None for a while now.
This comment has been minimized.
This comment has been minimized.
Also, fix the value to `None`, as it has effectively been since SAPI removed the answer time estimates.
randomir
force-pushed
the
remove-problem-eta-support
branch
from
509411d
to
bc90fb6
Compare
Get/set keys differed, resulting in python being installed every time.
randomir
added a commit
that referenced
this pull request
Jun 28, 2021
New Features --- - Annotated `Future.sampleset` with `.wait_id` method (#377) - Added `dispatches_events` decorator that can be used to simplify event dispatch on method entry and exit (#443/#455) - CLI: added `--client` option to override the client type used (#458) Fixes --- - Dispatch sampling events also from unstructured solvers (#454) - CLI: fixed solver by client filtering (#457) - Docs: added link checks (#464), updated sphinx/conf (#470) Changes --- - CLI: deprecated `-c` flag (short for `--config-file`) in favor of `-f` (#458) - Dropped Python 3.5 support (#467) - Deprecated `Future.{eta_min,eta_max}` (#468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying feature has already been removed from SAPI, but let's
provide a grace period for Ocean users. Although the return value has
been
Nonefor a while now.