Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Future.{eta_min,eta_max} #468

Merged
merged 3 commits into from
May 3, 2021
Merged

Deprecate Future.{eta_min,eta_max} #468

merged 3 commits into from
May 3, 2021

Commits on May 1, 2021

  1. Deprecate Future.{eta_min,eta_max} 

    The underlying feature has already been removed from SAPI, but let's
provide a grace period for Ocean users. Although the return value has
been None for a while now.
    @randomir
    randomir committed May 1, 2021
    Configuration menu
    Copy the full SHA
    ea966c0 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Make (deprecated) Future.eta_{min,max} properties read-only 

    Also, fix the value to `None`, as it has effectively been since SAPI
removed the answer time estimates.
    @randomir
    randomir committed May 3, 2021
    Configuration menu
    Copy the full SHA
    bc90fb6 View commit details
    Browse the repository at this point in the history

  2. Fix CI cache key for macos/pyenv 

    Get/set keys differed, resulting in python being installed every time.
    @randomir
    randomir committed May 3, 2021
    Configuration menu
    Copy the full SHA
    433cf78 View commit details
    Browse the repository at this point in the history