Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI #458

Conversation

randomir
Copy link
Member

Add --client to all relevant subcommands.

Fix --all on dwave solvers (#457).

Until now `--all` would not reset the `client`, but would use the
client type setting from config file/env. Hence, possibly not listing
all solvers.

Close dwavesystems#457.
Now supported on: ping, sample, solvers, upload.
Schedule `-c` for removal in 0.10+
In 0.11+, introduce `-c` for `--client`.
@randomir randomir force-pushed the bugfix/cli-solvers-all-sensitive-to-client-type/issue-457 branch from 88e68e0 to 80d231e Compare February 16, 2021 16:05
@randomir randomir force-pushed the bugfix/cli-solvers-all-sensitive-to-client-type/issue-457 branch from 80d231e to 5f87a96 Compare February 16, 2021 16:10
Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@randomir randomir merged commit b008a32 into dwavesystems:master Feb 22, 2021
@randomir randomir deleted the bugfix/cli-solvers-all-sensitive-to-client-type/issue-457 branch February 22, 2021 21:09
randomir added a commit that referenced this pull request Jun 28, 2021
New Features
---

- Annotated `Future.sampleset` with `.wait_id` method (#377)
- Added `dispatches_events` decorator that can be used to simplify event
  dispatch on method entry and exit (#443/#455)
- CLI: added `--client` option to override the client type used (#458)

Fixes
---

- Dispatch sampling events also from unstructured solvers (#454)
- CLI: fixed solver by client filtering (#457)
- Docs: added link checks (#464), updated sphinx/conf (#470)

Changes
---

- CLI: deprecated `-c` flag (short for `--config-file`) in favor
  of `-f` (#458)
- Dropped Python 3.5 support (#467)
- Deprecated `Future.{eta_min,eta_max}` (#468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants