-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CLI #458
Merged
randomir
merged 6 commits into
dwavesystems:master
from
randomir:bugfix/cli-solvers-all-sensitive-to-client-type/issue-457
Feb 22, 2021
Merged
Update CLI #458
randomir
merged 6 commits into
dwavesystems:master
from
randomir:bugfix/cli-solvers-all-sensitive-to-client-type/issue-457
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now `--all` would not reset the `client`, but would use the client type setting from config file/env. Hence, possibly not listing all solvers. Close dwavesystems#457.
Now supported on: ping, sample, solvers, upload.
Schedule `-c` for removal in 0.10+ In 0.11+, introduce `-c` for `--client`.
randomir
force-pushed
the
bugfix/cli-solvers-all-sensitive-to-client-type/issue-457
branch
from
February 16, 2021 16:05
88e68e0
to
80d231e
Compare
randomir
force-pushed
the
bugfix/cli-solvers-all-sensitive-to-client-type/issue-457
branch
from
February 16, 2021 16:10
80d231e
to
5f87a96
Compare
arcondello
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
randomir
deleted the
bugfix/cli-solvers-all-sensitive-to-client-type/issue-457
branch
February 22, 2021 21:09
randomir
added a commit
that referenced
this pull request
Jun 28, 2021
New Features --- - Annotated `Future.sampleset` with `.wait_id` method (#377) - Added `dispatches_events` decorator that can be used to simplify event dispatch on method entry and exit (#443/#455) - CLI: added `--client` option to override the client type used (#458) Fixes --- - Dispatch sampling events also from unstructured solvers (#454) - CLI: fixed solver by client filtering (#457) - Docs: added link checks (#464), updated sphinx/conf (#470) Changes --- - CLI: deprecated `-c` flag (short for `--config-file`) in favor of `-f` (#458) - Dropped Python 3.5 support (#467) - Deprecated `Future.{eta_min,eta_max}` (#468)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--client
to all relevant subcommands.Fix
--all
ondwave solvers
(#457).