Visualize FlowNode graph #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Feb 26, 2024
|
Oh my god. This is glorious 😍 I was dumping Thank you ❤️ |
|
Thanks @Andarist! Regardless of what happens to microsoft/TypeScript#57465, this is at least a nice, tangible win that came out of it. I found flow nodes completely incomprehensible until I did this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is significantly easier to understand than the antecedent tree view:
This does a BFS on the FlowNode graph (via
antecedent/antecedents) and produces a graph spec using dot format. It then uses viz-js to turn this into an SVG for display.If this is of interest, we can work on tuning the display, options and interactivity.
cc @JoshuaKGoldberg, who was interested in this