Handle both single and multiple antecedents in "antecedent" field #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change looks good to me. Thanks for tracking it down and fixing it. These are the hazards of depending on internal APIs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS v5.5 changed some stuff regarding flow types. One thing is that the
antecedentfield could be an array now.In fact, examples like this are quite broken now. If you select the last
return x, for example, you see that TS version5.5has renamed theantecedentsfield containing an array intoantecedent.This probably comes from an effort to normalize shape of those flows nodes to make them monomorphic.