Support dark mode, add graph link #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks, @danvk!
I temporarily removed the link to GraphvizOnline because it wasn't working in dark mode. I just realized right now as I'm typing it that it was probably loading the graph as white on a white background on the other website (maybe the graph link should be done in light mode when in dark mode?). Going to merge this fix without it for the time being, but it would be good to get your other changes in a separate PR if you're up for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138
I also added in a few tweaks that got dropped from #134. Feel free to remove the external link if you like — one nice thing about it is that it lets you pan and zoom around the control flow graph, which can be helpful if it gets large and is cut off in the ts-ast-viewer panel.