xPackage: Fix misnamed variable

[codykonior]

Pull Request (PR) description

There's a misnamed variable which causes an error during certain error output.

This Pull Request (PR) fixes the following issues

• Fixes xPackage: The variable '$Localized' cannot be retrieved because it has not been set. #449

Task list

• Added an entry under the Unreleased section of the change log in the README.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codykonior]

Try to trigger AppVeyor rebuild

[codykonior]

@johlju What's the plan here? It seems the build has been failing on multiple PRs for a while now.

[johlju]

Sorry have been very busy with the day job. :/ Will be back at it as soon as I can.

[johlju]

See the issue PKISolutions/PSPKI#56. We have to wait for the PSPKI module to be rereleased.

[codykonior]

Thanks so much for letting me know. Will wait ^^

[johlju]

A fix was merged to the test framework. Test framework is using the old working PSPKI module. So please close and reopen the PR by choosing Close PR and then press Reopen PR. This will trigger so the tests are run again.

[codecov-io]

Codecov Report

Merging #450 into dev will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff         @@
##            dev   #450   +/-   ##
===================================
  Coverage    72%    72%           
===================================
  Files        27     27           
  Lines      4031   4031           
  Branches      4      4           
===================================
  Hits       2922   2922           
  Misses     1105   1105           
  Partials      4      4

[codykonior]

All the failed tests are unrelated in xArchive.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[codykonior]

It’s not stale it’s waiting on merge or feedback.

[mhendric]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @codykonior)

---

DSCResources/MSFT_xPackageResource/MSFT_xPackageResource.psm1, line 897 at r1 (raw file):

$localizedData

Recommend changing this to $script:localizedData to align with all other usage of the localizedData variable in this file.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

[PlagueHO]

I've fixed the integration tests so hopefully this one will be able to be completed.

[mhendric]

Hi @codykonior , I still recommend changing $localizedData to $script:localizedData. Other than that, I think this just needs a rebase per the below article and it should be ready to go. Thanks for your contribution and your patience on this!

https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#resolve-merge-conflicts

[codykonior]

Trying to rebase just made everything 100,000x worse.

[codykonior]

Aborting this PR, I can't fix this.