Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable broken integration tests #459

Closed
wants to merge 1 commit into from

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Nov 9, 2018

Pull Request (PR) description

Disables Integration Tests in MSFT_xArchive.EndToEnd.Tests.ps1, MSFT_xArchive.Integration.Tests.ps1, and MSFT_xWindowsProcess.Integration.Tests.ps1 until #457 and #458 can be resolved. These two issues are currently causing a number of Pull Requests to fail during the AppVeyor build process, even though those PR's are for unrelated code. Currently affected PR's include #446, #448, #450, #455.

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #459 into dev will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #459    +/-   ##
====================================
+ Coverage    72%    72%   +<1%     
====================================
  Files        27     27            
  Lines      4016   4016            
  Branches      4      4            
====================================
+ Hits       2916   2929    +13     
+ Misses     1096   1083    -13     
  Partials      4      4

@stale
Copy link

stale bot commented Nov 23, 2018

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale bot added the abandoned The pull request has been abandoned. label Nov 23, 2018
@PlagueHO
Copy link
Member

Hi @mhendric - I'm going to close this one now as the integration tests are now working again. 😁

@PlagueHO PlagueHO closed this Jan 19, 2019
@PlagueHO PlagueHO removed the abandoned The pull request has been abandoned. label Jan 25, 2019
@mhendric mhendric deleted the DisableBrokenTests branch February 7, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants