Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xPackage: Fix misnamed variable #450

Closed
wants to merge 138 commits into from
Closed
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
685fd6d
#449 misnamed variable
codykonior Oct 16, 2018
e23e0ca
Update CHANGELOG
codykonior Oct 16, 2018
2aa9db6
Update CHANGELOG
codykonior Oct 16, 2018
a747191
Merge branch 'dev' into dev
PlagueHO Jan 19, 2019
b2f6a55
Merge branch 'dev' into dev
PlagueHO Jan 25, 2019
a08df20
Merge branch 'dev' into dev
PlagueHO Jan 26, 2019
2f36996
Update MSFT_xPackageResource.psm1
mhendric Jan 26, 2019
9060791
Merge branch 'dev' into dev
mhendric Jan 26, 2019
ce224d1
Merge branch 'dev' into dev
mhendric Jan 27, 2019
230e664
Update README.md
mhendric Jan 27, 2019
00bcde5
Merge branch 'dev' into dev
mhendric Jan 27, 2019
001cd52
Merge branch 'dev' into dev
mhendric Jan 28, 2019
07a84d5
updated conditional statement
harnsin Oct 9, 2018
0620ea4
updated readme
harnsin Oct 9, 2018
d5fcc7c
Update README.md
mhendric Jan 26, 2019
c330c0c
Update README.md
mhendric Jan 27, 2019
b6a9951
Merge branch 'dev' of https://github.com/codykonior/xPSDesiredStateCo…
codykonior Feb 17, 2019
8e8f4e7
Changes to xPSDesiredStateConfiguration
johlju Jan 28, 2019
1ff0afe
Fix review comment at r1
johlju Jan 28, 2019
f9e9d13
Remove code from non-testfile
johlju Jan 28, 2019
51a83e2
FIx review comment at r3
johlju Jan 29, 2019
e4af8b0
Fix review comments at r4
johlju Jan 30, 2019
a7c51c7
Run Codecov only on one image
johlju Jan 30, 2019
341ada4
Switch to running tests for latest OS first (including meta tests)
johlju Feb 1, 2019
cca9f70
Fix review comments at r7
johlju Feb 2, 2019
52aa335
Update deploy step in appveyor.yml
johlju Feb 2, 2019
1dc0713
Update appveyor.yml
johlju Feb 2, 2019
b20aad0
Update appveyor.yml
johlju Feb 2, 2019
e84f222
Update appveyor.yml
johlju Feb 2, 2019
70c2b0b
Move Change History to CHANGELOG.MD
mhendric Jan 31, 2019
32434a7
Move Change History to CHANGELOG.MD
mhendric Jan 31, 2019
6d478fd
Move Change History to CHANGELOG.MD
mhendric Jan 31, 2019
f6f9b9d
Fix README.md markdown issues
mhendric Jan 31, 2019
b9c032d
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
ae39dd5
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
c336301
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
6ddf5c8
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
035db92
Fix README.md markdown issues
mhendric Jan 31, 2019
a4d8a79
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
4777693
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
1d5adb3
Fix HighQualityResourceModulePlan.md markdown issues
mhendric Jan 31, 2019
bac39d2
Move Change History to CHANGELOG.MD
mhendric Feb 1, 2019
f6f6c06
Move Change History to CHANGELOG.MD
mhendric Feb 1, 2019
cac62f9
Fix HighQualityResourceModulePlan.md markdown issues - Post Review #1
mhendric Feb 2, 2019
8289ab1
Fix HighQualityResourceModulePlan.md markdown issues - Post Review #1
mhendric Feb 2, 2019
3011f84
Correct Style Guideline violation in xGroup
PlagueHO Jan 28, 2019
bf7df72
Renamed Clear-GroupMembers helper function to Clear-GroupMember to re…
PlagueHO Feb 2, 2019
be5971c
Clean up uneccessary line in README.MD
PlagueHO Feb 2, 2019
b4c233d
Corrected Style Violations in xWindowsProcess
PlagueHO Feb 3, 2019
0df0b96
Correct last violation in xWindowsProcess
PlagueHO Feb 3, 2019
0e3c6a5
Undo version 8.5.0.0 in CHANGELOG.md
mhendric Feb 3, 2019
cf2e3b7
Correct GitHUb PR Template
PlagueHO Feb 3, 2019
8d67c69
Fix most script analyzer issues in PSWSIISEndpoint.psm1
mhendric Jan 27, 2019
dcf212d
Fix most script analyzer issues in PSWSIISEndpoint.psm1
mhendric Jan 27, 2019
cc1aee2
Fix most script analyzer issues in PSWSIISEndpoint.psm1
mhendric Jan 27, 2019
6a0280a
Fix most script analyzer issues in PSWSIISEndpoint.psm1
mhendric Jan 27, 2019
a977db7
Fix most script analyzer issues in PSWSIISEndpoint.psm1
mhendric Jan 31, 2019
1f1469d
FixPSWSIISEndpoint - Post Review #1
mhendric Feb 2, 2019
2625f1b
FixPSWSIISEndpoint - Post Review #1
mhendric Feb 2, 2019
9572296
FixPSWSIISEndpoint - Post Review #2
mhendric Feb 2, 2019
c6c1c94
Removed forced verbose logging
raandree Feb 5, 2019
1c5ab42
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 3, 2019
820cdd3
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 3, 2019
b7b9fbf
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 3, 2019
806a23b
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 3, 2019
ad3a795
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
bc2bb48
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
a2a563c
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
f07d274
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
f58907a
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
40455d2
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
81f3bb9
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
4b7b2d1
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
f7e50e0
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
40e0559
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
9cc3602
Add New MSFT_xDSCWebService Integration Tests
mhendric Feb 4, 2019
31c08e4
Add New MSFT_xDSCWebService Integration Tests - Post Review #1
mhendric Feb 5, 2019
272b962
Add New MSFT_xDSCWebService Integration Tests - Post Review #2
mhendric Feb 5, 2019
a9bb61a
Resolve PSSA Violations in xRegistryResource
PlagueHO Feb 7, 2019
31eefbd
Fix script analyzer issues in UseSecurityBestPractices.psm1
mhendric Feb 4, 2019
5a59b88
Fix script analyzer issues in UseSecurityBestPractices.psm1
mhendric Feb 5, 2019
6c91ab3
Fix script analyzer issues in UseSecurityBestPractices.psm1
mhendric Feb 5, 2019
31bc151
Fix script analyzer issues in xEnvironmentResource
mhendric Feb 5, 2019
424b9d8
Fix script analyzer issues in xEnvironmentResource
mhendric Feb 5, 2019
0c5382e
Fix script analyzer issues in xEnvironmentResource
mhendric Feb 5, 2019
5706d4a
Fix script analyzer issues in xEnvironmentResource
mhendric Feb 7, 2019
e50f8e3
Fix script analyzer issues in xMsiPackage
mhendric Feb 5, 2019
2ed0c1c
Fix script analyzer issues in xMsiPackage
mhendric Feb 6, 2019
bfdac73
Fix script analyzer issues in xMsiPackage - Post Review #1
mhendric Feb 7, 2019
71fe000
Fix script analyzer issues in MSFT_xPackageResource
mhendric Feb 6, 2019
723206f
Fix script analyzer issues in MSFT_xPackageResource
mhendric Feb 6, 2019
6d33ce9
Fix script analyzer issues in MSFT_xPackageResource - Post Review #1
mhendric Feb 7, 2019
def587c
Fix script analyzer issues in MSFT_xPackageResource - Post Review #1
mhendric Feb 7, 2019
312d89e
Add spaces between variable types and variables.
mhendric Feb 7, 2019
9b4df55
Add spaces between variable types and variables.
mhendric Feb 7, 2019
5adc8b4
Add spaces between variable types and variables.
mhendric Feb 7, 2019
c539e0f
Add spaces between variable types and variables. - Post Review #1
mhendric Feb 8, 2019
2985436
Resolve PSSA issues in xPSSessionConfiguration
PlagueHO Feb 9, 2019
ef30cce
Correct xPSSessionConfiguration exported function names
PlagueHO Feb 9, 2019
a2715f1
Fix spelling error in CHANGELOG.MD
PlagueHO Feb 12, 2019
736202c
Add spaces between array members
mhendric Feb 7, 2019
9408009
Add spaces between array members
mhendric Feb 7, 2019
e1c84dc
Add spaces between array members
mhendric Feb 7, 2019
1c76e2e
Fix PSSA violations in xRemoteFile
PlagueHO Feb 10, 2019
ff7f7db
Correct name of xRemoteFile Strings file
PlagueHO Feb 10, 2019
a73aba0
Corrections to xRemoteFile as per PR comments
PlagueHO Feb 13, 2019
89a054c
Remove unnecessary whitespace from line endings.
mhendric Feb 7, 2019
540e78a
Remove unnecessary whitespace from line endings.
mhendric Feb 7, 2019
b976e6f
Remove unnecessary whitespace from line endings.
mhendric Feb 7, 2019
b1ae18e
Remove unnecessary whitespace from line endings.
mhendric Feb 8, 2019
a774ab6
Add statement to README.md regarding the lack of testing of this modu…
mhendric Feb 14, 2019
cf494bf
Fixes script analyzer issues in MSFT_xWindowsOptionalFeature.psm1
PlagueHO Feb 15, 2019
91bba7d
Fix missed PSSA violations
PlagueHO Feb 15, 2019
4c0ef5d
Add space between comment hashtags and comments
mhendric Feb 7, 2019
6d02e80
Add space between comment hashtags and comments
mhendric Feb 7, 2019
a1e72bd
Add space between comment hashtags and comments
mhendric Feb 7, 2019
a2e7297
Add space between comment hashtags and comments - Post Review #1
mhendric Feb 13, 2019
8bc2661
Add space between comment hashtags and comments - Post Review #2
mhendric Feb 15, 2019
e236fbb
Fixes script analyzer issues in MSFT_xServiceResource.psm1
mhendric Feb 15, 2019
c00ab4e
Fixes script analyzer issues in MSFT_xServiceResource.psm1 - Post Rev…
mhendric Feb 15, 2019
4209486
Fix script analyzer issues in MSFT_xUserResource.psm1
mhendric Feb 15, 2019
42fbe7c
Fix script analyzer issues in MSFT_xWindowsFeature.psm1.
mhendric Feb 15, 2019
7cf7d16
Moves calls to set $global:DSCMachineStatus = 1 into a helper function
mhendric Feb 14, 2019
795f906
Moves calls to set $global:DSCMachineStatus = 1 into a helper function
mhendric Feb 14, 2019
7f3d081
Moves calls to set $global:DSCMachineStatus = 1 into a helper function
mhendric Feb 15, 2019
6c0eda9
Moves calls to set $global:DSCMachineStatus = 1 into a helper functio…
mhendric Feb 15, 2019
5df6556
Moves calls to set $global:DSCMachineStatus = 1 into a helper functio…
mhendric Feb 15, 2019
614234e
Moves calls to set $global:DSCMachineStatus = 1 into a helper functio…
mhendric Feb 15, 2019
9506300
Moves calls to set $global:DSCMachineStatus = 1 into a helper functio…
mhendric Feb 15, 2019
ae85e7c
Add space between comment hashtags and comments - Post Review #3
mhendric Feb 15, 2019
a319e4f
Fix script analyzer issues in MSFT_xWindowsFeature.psm1 - Post Review #1
mhendric Feb 15, 2019
fa9e62a
Fixes script analyzer issues in MSFT_xWindowsPackageCab.psm1
PlagueHO Feb 16, 2019
b65a578
Fixed PSSA issues in xFileUpload and added Integration tests
PlagueHO Feb 16, 2019
e0cd99b
Correct parameter in xFileUpload
PlagueHO Feb 16, 2019
8df54da
Correct quotes in xFileUpload
PlagueHO Feb 16, 2019
17dffd1
Removed Import-ModuleDsc from xFileUpload
PlagueHO Feb 16, 2019
bede2d6
Change the integration tests to import the module
PlagueHO Feb 16, 2019
48589e8
Fixes to xFileUpload as per PR comments
PlagueHO Feb 16, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -894,7 +894,7 @@ function Convert-PathToUri

if ($validUriSchemes -notcontains $uri.Scheme)
{
Write-Verbose -Message ($Localized.TheUriSchemeWasUriScheme -f $uri.Scheme)
Write-Verbose -Message ($script:localizedData.TheUriSchemeWasUriScheme -f $uri.Scheme)
New-InvalidArgumentException -ArgumentName 'Path' -Message ($script:localizedData.InvalidPath -f $Path)
}

Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,9 @@ Publishes a 'FileInfo' object(s) to the pullserver configuration repository. It
* Changes to xService
* Added support for Group Managed Service Accounts

* Changes to xPackage
* Fixed an issue where an error occurs during error message output. ([issue #449](https://github.com/PowerShell/xPSDesiredStateConfiguration/issues/449))

### 8.4.0.0

* Changes to xPSDesiredStateConfiguration
Expand Down