Adding Text pattern to UpDownControls

[vladimir-krestov]

Fixes #1588

Proposed changes

• Enable Text pattern support for UpDownEditAccessibleObject

Customer Impact

• Visually impaired users will be able to read and interact with the text content of a UpDownControls

Regression?

• No

Risk

• Minimal

Before

• Narrator does not announce the text navigation and selection of a UpDownControls

After

• Narrator announces the text content of a UpDownControls (navigation, selection)

Test methodology

• Manual testing
• CTI
• Unit tests

Accessibility testing

• Using Narrator and Inspect

Test environment(s)

• .Net 5.0 Version: 5.0.0-rc.1.20431.5
• Microsoft Windows [Version 10.0.19041.450]

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Merging #3878 into release/5.0-rc2 will decrease coverage by 30.92951%.
The diff coverage is 82.14286%.

@@                    Coverage Diff                     @@
##           release/5.0-rc2       #3878          +/-   ##
==========================================================
- Coverage         67.85203%   36.92252%   -30.92951%     
==========================================================
  Files                 1414         924         -490     
  Lines               507525      251004      -256521     
  Branches             41184       36986        -4198     
==========================================================
- Hits                344366       92677      -251689     
+ Misses              157033      152877        -4156     
+ Partials              6126        5450         -676     

Flag	Coverage Δ
#Debug	36.92252% <82.14286%> (-30.92952%)	⬇️
#production	36.92252% <82.14286%> (-0.00340%)	⬇️
#test	?

Flags with carried forward coverage won't be shown. Click here to find out more.

[vladimir-krestov]

I implemented Text pattern for UpDownEdit and now it has the following behavior (I'm clicking the Up keyboard arrow):

Text pattern works expectedly, but the Narrator blue rectangle jumps when clicking "Up/Down" keyboard arrows when NumericUpDown has the 2-digit value.
This behavior can seem confusing but I think all right because this is expected Text pattern behavior. Like in RichTextBox that supports Text pattern from Win32:

Here you can see the same Narrator steps:

• Click the Up/Down keyboard arrow
• Narrator reads a whole line where the caret is
• Narrator shows the blue rectangle for a character after the caret

I think the current NumericUpDown Text pattern behavior is correct. @merriemcgaw, @Tanya-Solyanik, could you please approve my thoughts?

[merriemcgaw]

@SergeySmirnov-Akvelon @vladimir-krestov - does this impact the non-narrator situation where currently up/down arrows are used to increase/decrease the value in the box? Would that still work with this text pattern?

[vladimir-krestov]

@merriemcgaw No, Text pattern doesn't impact the non-narrator situation. This is needed only to Narrator announces UpDown characters correctly.
You won't notice the change without Narrator.
@merriemcgaw Will we keep the current implementation? (#3878 (comment))

[merriemcgaw]

@vladimir-krestov that looks good to me. Does the Narrator user get to head over to the up/down controls next to the edit and use them as usual?
@Olina-Zhang, let us know the test results ASAP.
@SteveCarrollMSFT this should be the last thing we bring for the TextPattern support, and then we're compliant for this UIA pattern!

[RussKie]

Need to tighten up the validation.

[vladimir-krestov]

@merriemcgaw Now it has some differences, but a user hears the same.

In the rest, UpDown controls work as usual. A user can navigate to these controls and move from them to other controls on a form using "Tab".

[vladimir-krestov]

Testers approved the fix ✔️
But there are some test issues:

• Narrator doesn't announce a new value sometimes if to click Up/Down buttons using a mouse
  
  It happens in the first running. Also, using Narrator with a mouse is not the common scenario. So moved the issue to .Net 6.0. It won't be fixed here.
• The Narrator blue rectangle has some little differences in different OS versions. They are not critical for a user. And it seems it is Narrator issue.

But the main Issue #1588 was fixed.