Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility Insights] An element of the given ControlType must support the Text pattern for edit controls: TextBox/MaskedTextBox/ComboBox/NumericUpDown/DomainUpDown #1588

Closed
5 tasks done
Marie-Shi opened this issue Aug 8, 2019 · 3 comments · Fixed by #2701 or #3878
Closed
5 tasks done

[Accessibility Insights] An element of the given ControlType must support the Text pattern for edit controls: TextBox/MaskedTextBox/ComboBox/NumericUpDown/DomainUpDown #1588

Marie-Shi opened this issue Aug 8, 2019 · 3 comments · Fixed by #2701 or #3878
Assignees
@vladimir-krestov
Labels
a11yMAS High Priority - Accessibility violation of Microsoft Accessibility Standards 🪲 bug Product bug (most likely) tenet-accessibility MAS violation, UIA issue; problems with accessibility standards

Comments

@Marie-Shi
Copy link

Marie-Shi commented Aug 8, 2019 •
edited by RussKie
Loading

  • .NET Core Version: .NET Core 3.0.100-preview8-013656 from release branch
  • Have you experienced this same bug with .NET Framework? Yes

Affected controls:
TextBox/MaskedTextBox/ComboBox/NumericUpDown/DomainUpDown

Problem description:

  1. Install the .NET Core 3.0 SDK from https://github.com/dotnet/core-sdk.
  2. Open the attached ‘NumericUpDown_DomainUpDown’ .NET Core app in VS.
    NumericUpDown_DomainUpDown.zip
  3. Build and run it.
  4. Start Accessibility Insights for Windows and test NumericUpDown and DomainUpDown controls in Form.

Actual behavior:
An element of the given ControlType doesn’t support the Text pattern.
Violation: Section 508 502.3.10
Please see the below Screenshot:
NumericUpDown:
NumericUpDown

DomainUpDown:
DomainUpDown

Expected behavior:
NumericUpDown and DomainUpDown eidt should support the Text pattern.

[EDIT]
@Marie-Shi Marie-Shi changed the title [Accessibility Insights] An element of the given ControlType must support the Text pattern of NumericUpDown/DomainUpDown [Accessibility Insights] An element of the given ControlType must support the Text pattern of NumericUpDown/DomainUpDown edit Aug 8, 2019
@Marie-Shi Marie-Shi changed the title [Accessibility Insights] An element of the given ControlType must support the Text pattern of NumericUpDown/DomainUpDown edit [Accessibility Insights] An element of the given ControlType must support the Text pattern for edit controls: TextBox/MaskedTextBox/ComboBox/NumericUpDown/DomainUpDown Aug 8, 2019
@merriemcgaw merriemcgaw added this to the 3.0.0-GA milestone Aug 9, 2019
@zsd4yr zsd4yr added tenet-accessibility MAS violation, UIA issue; problems with accessibility standards 🪲 bug Product bug (most likely) labels Aug 16, 2019
@zsd4yr
Copy link
Contributor

zsd4yr commented Aug 16, 2019

@M-Lipin assigning to you

@RussKie RussKie added the a11yMAS High Priority - Accessibility violation of Microsoft Accessibility Standards label Aug 16, 2019
@RussKie RussKie modified the milestones: 3.0-GA, 3.1 Sep 16, 2019
@karanbirsingh karanbirsingh mentioned this issue Sep 19, 2019
Closed
@DaveTryon DaveTryon mentioned this issue Oct 17, 2019
Closed
@DaveTryon DaveTryon mentioned this issue Oct 28, 2019
Closed
@M-Lipin M-Lipin self-assigned this Oct 29, 2019
@RussKie RussKie modified the milestones: 3.1, 5.0 Nov 28, 2019
@M-Lipin M-Lipin mentioned this issue Jan 13, 2020
Merged
@ghost ghost added the 🚧 work in progress Work that is current in progress label Jan 13, 2020
@RussKie RussKie modified the milestones: 5.0 Previews 1-4, 5.0 Apr 20, 2020
@ghost ghost added 🚧 work in progress Work that is current in progress and removed 🚧 work in progress Work that is current in progress labels Aug 7, 2020
@Marie-Shi Marie-Shi mentioned this issue Aug 21, 2020
Closed
@merriemcgaw merriemcgaw modified the milestones: 5.0, 5.0 RC2 Sep 1, 2020
vladimir-krestov added a commit to vladimir-krestov/winforms that referenced this issue Sep 8, 2020
@vladimir-krestov
Implement TextPattern support for Text controls
b8680ad 
- Implement base integration to AccessibleObject
- Add TextPattern support for TextBox (singleline and multiline) and MaskedTextBox
- Disable managed UiaTextProvider for RichTextBox to use native provider as the native
  Win32 RichEdit control already supports TextPattern.
  Return ControlAccessibleObject as AccessibilityInstance instead TextBoxBaseAccessibleObject
  (the latter supports managed UiaTextProvider).
- Add tests

Fixes dotnet#1588

(cherry picked from commit f2baffc)
@vladimir-krestov vladimir-krestov mentioned this issue Sep 8, 2020
Closed
This was referenced Sep 10, 2020
Merged
Closed
@RussKie RussKie linked a pull request Sep 21, 2020 that will close this issue
Adding Text pattern to UpDownControls #3878
Merged
vladimir-krestov added a commit to vladimir-krestov/winforms that referenced this issue Sep 23, 2020
@vladimir-krestov
Implement Text pattern for UpDown
7b9b41c 
Fixes dotnet#1588
@ghost ghost removed the 🚧 work in progress Work that is current in progress label Sep 23, 2020
@RussKie RussKie removed this from the 5.0 RC2 milestone Sep 23, 2020
@merriemcgaw merriemcgaw modified the milestones: 5.0 RC2, 6.0 Preview1 Sep 25, 2020
@merriemcgaw
Copy link
Member

Just need to get this ported to 6.

@Marie-Shi
Copy link
Author

Marie-Shi commented Oct 9, 2020 •
edited
Loading

Verified this issue with .Net 6.0.100-alpha.1.20506.3 from master branch, it is fixed. Now those controls(TextBox, MaskedTextBox, ComboBox, NumericUpDown, DomainUpDown, RichTextBox) support the Text pattern.
Untitled

@RussKie RussKie removed this from the 6.0 Preview1 milestone Oct 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vladimir-krestov vladimir-krestov

Labels
a11yMAS High Priority - Accessibility violation of Microsoft Accessibility Standards 🪲 bug Product bug (most likely) tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Projects
None yet
Milestone
No milestone
6 participants
@RussKie @zsd4yr @merriemcgaw @M-Lipin @Marie-Shi @vladimir-krestov