Merge pull request #3878 from vladimir-krestov/Issue_1588_AddingTextP…

…attern_to_UpDownControls

src/System.Windows.Forms/src/Resources/SR.resx

@@ -6731,4 +6731,7 @@ Stack trace where the illegal operation occurred was:
   <data name="PropertyGridViewDropDownControlHolderAccessibleName" xml:space="preserve">
     <value>Drop down control holder</value>
   </data>
+  <data name="UpDownEditLocalizedControlTypeName" xml:space="preserve">
+    <value>Edit</value>
+  </data>
 </root>

src/System.Windows.Forms/src/System/Windows/Forms/UpDownBase.UpDownEdit.UpDownEditAccessibleObject.cs

@@ -0,0 +1,57 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using static Interop;
+
+namespace System.Windows.Forms
+{
+    public abstract partial class UpDownBase
+    {
+        internal partial class UpDownEdit
+        {
+            internal class UpDownEditAccessibleObject : ControlAccessibleObject
+            {
+                private readonly UpDownEdit _owningUpDownEdit;
+                private readonly TextBoxBaseUiaTextProvider _textProvider;
+                private readonly UpDownBase _parent;
+
+                public UpDownEditAccessibleObject(UpDownEdit owner, UpDownBase parent) : base(owner)
+                {
+                    _parent = parent ?? throw new ArgumentNullException(nameof(parent));
+                    _owningUpDownEdit = owner;
+                    _textProvider = new TextBoxBaseUiaTextProvider(owner);
+                    UseTextProviders(_textProvider, _textProvider);
+                }
+
+                internal override bool IsIAccessibleExSupported() => true;
+
+                public override string? Name
+                {
+                    get => _parent.AccessibilityObject.Name;
+                    set => _parent.AccessibilityObject.Name = value;
+                }
+
+                public override string? KeyboardShortcut => _parent.AccessibilityObject.KeyboardShortcut;
+
+                internal override object? GetPropertyValue(UiaCore.UIA propertyID)
+                    => propertyID switch
+                    {
+                        UiaCore.UIA.IsTextPatternAvailablePropertyId => IsPatternSupported(UiaCore.UIA.TextPatternId),
+                        UiaCore.UIA.IsTextPattern2AvailablePropertyId => IsPatternSupported(UiaCore.UIA.TextPattern2Id),
+                        _ => base.GetPropertyValue(propertyID),
+                    };
+
+                internal override bool IsPatternSupported(UiaCore.UIA patternId)
+                    => patternId switch
+                    {
+                        UiaCore.UIA.TextPatternId => true,
+                        UiaCore.UIA.TextPattern2Id => true,
+                        _ => base.IsPatternSupported(patternId)
+                    };
+
+                internal override bool IsReadOnly => _owningUpDownEdit.ReadOnly;
+            }
+        }
+    }
+}

src/System.Windows.Forms/src/System/Windows/Forms/UpDownBase.UpDownEdit.cs

@@ -1,4 +1,4 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
@@ -11,7 +11,7 @@ namespace System.Windows.Forms
 {
     public abstract partial class UpDownBase
     {
-        internal class UpDownEdit : TextBox
+        internal partial class UpDownEdit : TextBox
         {
             private readonly UpDownBase _parent;
             private bool _doubleClickFired;
@@ -30,11 +30,13 @@ public override string Text
                 set
                 {
                     bool valueChanged = (value != base.Text);
-                    base.Text = value;
                     if (valueChanged)
                     {
-                        AccessibilityNotifyClients(AccessibleEvents.NameChange, -1);
+                        AccessibilityObject.RaiseAutomationNotification(Automation.AutomationNotificationKind.ActionCompleted,
+                            Automation.AutomationNotificationProcessing.CurrentThenMostRecent, SR.UpDownEditLocalizedControlTypeName);
+                        AccessibilityObject.RaiseAutomationEvent(UiaCore.UIA.Text_TextChangedEventId);
                     }
+                    base.Text = value;
                 }
             }
 
@@ -108,24 +110,6 @@ protected override void OnGotFocus(EventArgs e)
 
             protected override void OnLostFocus(EventArgs e)
                 => _parent.InvokeLostFocus(_parent, e);
-
-            internal class UpDownEditAccessibleObject : ControlAccessibleObject
-            {
-                readonly UpDownBase _parent;
-
-                public UpDownEditAccessibleObject(UpDownEdit owner, UpDownBase parent) : base(owner)
-                {
-                    _parent = parent;
-                }
-
-                public override string Name
-                {
-                    get => _parent.AccessibilityObject.Name;
-                    set => _parent.AccessibilityObject.Name = value;
-                }
-
-                public override string KeyboardShortcut => _parent.AccessibilityObject.KeyboardShortcut;
-            }
         }
     }
 }