Improve call counting mechanism #32250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got a consistent repro of the crash after a few hours of running a CoreFX test suite, verified no repro after fix after 12+ hours. Got one repro of the assertion failure, currently running again after fix, will continue running overnight. |
kouvel
force-pushed
the
CallCounting
branch
2 times, most recently
from
fdd45b5
to
40f1a7f
Compare
|
No assertion failure after 12+ hours after fix. Rebased to fix conflicts. |
|
Thanks @noahfalk! Rebased to latest to run through the checks again. |
|
Failures are same as #32951 |
- Commit 1 - Reverts commit f954c6b, which reverted PR dotnet#1457 due to issues - Commit 2 - Fixes crashes and assertion failures seen by the original change, fixes dotnet#29934 - The crashes were caused by commit dotnet@6aa3c70 in the original PR - Call counting infos cannot be deleted when the corresponding call counting stubs may still run, because: - The remaining call count decremented by the stub is in the call counting info - The only way to get a code version / method desc from a stub is to go through the call counting info - Got one repro of the assertion failure in dotnet#22786 and it is most likely caused by the same issue, following heap corruption from modifying a deleted call counting info where the memory is reused for a `NativeCodeVersionNode`, messing up the method desc pointer - Fixed with a partial revert of the above commit. Added back the `Complete` stage and then call counting infos are deleted only after it's ensured that call counting stubs won't be used (shortly before deleting them). - Commit 3 - Public static functions of `CallCountingManager` that may be called through the debugger may occur before static initialization, added a check for null as suggested in dotnet#29892
|
Rebased to fix conflict |
gbalykov
added a commit
to gbalykov/runtime
that referenced
this pull request
Apr 4, 2020
Related to dotnet#32250
jkotas
pushed a commit
that referenced
this pull request
Apr 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completestage and then call counting infos are deleted only after it's ensured that call counting stubs won't be used (shortly before deleting them).CallCountingManagerthat may be called through the debugger may occur before static initialization, added a check for null as suggested in Fix createdump DAC segfault #29892