Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove runtime suspension when updating active IL version in ReJIT #13442

Closed
davmason opened this issue Sep 19, 2019 · 1 comment
Closed

Remove runtime suspension when updating active IL version in ReJIT #13442

davmason opened this issue Sep 19, 2019 · 1 comment
Assignees
@davmason
Labels
area-Diagnostics-coreclr tracking This issue is tracking the completion of other related issues.
Milestone
Future

Comments

@davmason
Copy link
Member

Right now we suspend the runtime when updating the active IL version. I believe this was only required for jumpstamps, since we had to stop the runtime to make sure no threads were going to have a race in executing the prolog of a jitted method. dotnet/coreclr#26740 makes it so ReJIT no longer uses jumpstamps, it should be safe to stop suspending the runtime.
@davmason davmason self-assigned this Sep 19, 2019
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@tommcdon tommcdon added the tracking This issue is tracking the completion of other related issues. label May 6, 2020
@tommcdon tommcdon modified the milestones: 5.0, Future May 6, 2020
@davmason
Copy link
Member Author

Fixed in #32250

@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davmason davmason

Labels
area-Diagnostics-coreclr tracking This issue is tracking the completion of other related issues.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@msftgits @davmason @tommcdon