Fix Win64 exception propagation in NativeCallable methods #33653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change has removed the UMThunkStub usage for native callable methods. That has broken handling of exceptions propagated from the managed native callable method into the native caller in case there were explicit frames below the native frame, like during the GC stress 3. This change fixes it by unwinding the explicit frames upto the native frame during the 2nd pass of exception handling when exception unwinding passes through the frame of a native callable method and isn't handled there.
|
cc: @AaronRobinsonMSFT |
jkotas
approved these changes
Mar 16, 2020
AaronRobinsonMSFT
approved these changes
Mar 16, 2020
|
Merging in first along with #33615 to address the various issues. |
gbalykov
added a commit
to gbalykov/runtime
that referenced
this pull request
Apr 4, 2020
Related to dotnet#33653, dotnet#33005
jkotas
pushed a commit
that referenced
this pull request
Apr 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change has removed the UMThunkStub usage for native callable
methods. That has broken handling of exceptions propagated from the
managed native callable method into the native caller in case there were
explicit frames below the native frame, like during the GC stress 3.
This change fixes it by unwinding the explicit frames upto the native
frame during the 2nd pass of exception handling when exception unwinding
passes through the frame of a native callable method and isn't handled
there.