-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove system zlib packages from unix native dependencies #105373
Closed
carlossanlop opened this issue
Jul 24, 2024
· 4 comments
· Fixed by #105419, #111939 or dotnet/arcade#15466
Closed
Remove system zlib packages from unix native dependencies #105373
carlossanlop opened this issue
Jul 24, 2024
· 4 comments
· Fixed by #105419, #111939 or dotnet/arcade#15466
Labels
Milestone
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Reopening as the PR was resubmitted: #105450 |
nil4
added a commit
to royalapplications/royalvnc
that referenced
this issue
Oct 21, 2024
Build with `ZLIB_COMPAT=yes` and deploy to `Sources/Z-win` `zlib-ng` builds on Windows without baroque workarounds - ref. dotnet/runtime#101465 - ref. dotnet/runtime#105373
Seems one place is still there, from a file that was moved to another folder and renamed. |
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Follow up of #105371
We can't yet remove the system zlib packages from the package installation branches in
install-native-dependencies.sh
because we don't yet consume an SDK version that includes zlib-ng.If we remove them from this script, and we attempt to run it in a new machine, then try to build runtime with:
We see this error:
Once we start consuming an SDK version that includes zlib-ng, we can remove those 3 references from the script:
zlib1g-dev
,zlib-devel
andzlib-dev
.runtime/eng/install-native-dependencies.sh
Lines 26 to 33 in c5b2dcd
And also remove mentions of zlib in the instructions:
https://github.com/dotnet/runtime/blob/main/docs/workflow/requirements/linux-requirements.md
The text was updated successfully, but these errors were encountered: