Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Remove zlib from requirements script and instruction files"" #105450

Conversation

stephentoub
Copy link
Member

From #105419:

Fixes #105373

Follow up of: #105371

Important: We should merge this when runtime consumes a version of the SDK that already includes the zlib-ng changes, otherwise the script will break.

@stephentoub stephentoub added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jul 25, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 25, 2024
@stephentoub stephentoub added area-System.IO.Compression blocked Issue/PR is blocked on something - see comments and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 25, 2024
@carlossanlop carlossanlop self-assigned this Jul 25, 2024
@stephentoub stephentoub added this to the 9.0.0 milestone Jul 31, 2024
@stephentoub
Copy link
Member Author

stephentoub commented Aug 15, 2024

#106333 was merged. @carlossanlop, can this be merged as well, or does it require an even newer SDK?

@stephentoub
Copy link
Member Author

@carlossanlop, I'm going to close this and you can re-open when you're ready for it.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@stephentoub stephentoub deleted the revert-105449-revert-105419-RemoveZlibFromScriptAndInstructions branch October 10, 2024 22:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO.Compression blocked Issue/PR is blocked on something - see comments NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove system zlib packages from unix native dependencies
2 participants