-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove zlib dependencies from eng/common/native/install-dependencies.sh #15466
Conversation
Nothing broke but I think I should go back to draft and first test this change in a test PR in the runtime repo, just in case any CI leg fails. |
I think to truly validate this, you need to build the docker images with the updates build-rootfs script and make sure that we can still build all branches we're still servicing with the new images. |
This script is not used in CI by arcade and runtime repos. It's used by https://github.com/dotnet/dotnet-buildtools-prereqs-docker and it's used for older versions of prereq containers from the main branch as well (servicing branches). Testing is done in multiple steps (build prereq image, then use that container image to build runtime), usually in local machine. |
Alright. But can I still assume that the change needs to be made here in arcade? @am11 I don't know how the code flows from between arcade and the prereqs repo. |
@carlossanlop, I think there are two opposing thought processes:
|
@carlossanlop There is a conversation about this on Teams (Build Tools Prereqs V-Team) |
Closing as the changes are more complex than just this. |
@carlossanlop Can we keep the cleanup in install-dependencies.sh? I do not think that install-dependencies.sh suffers from the problematic use in the prereqs repo. |
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes dotnet/runtime#105373
Follow up of dotnet/runtime#111939