Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick info merge master vs deps #25776

Merged

Conversation

JieCarolHu
Copy link
Contributor

Ask Mode template not completed

Customer scenario

What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)

Bugs this fixes

(either VSO or GitHub links)

Workarounds, if any

Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW

Risk

This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code

Performance impact

(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")

Is this a regression from a previous update?

Root cause analysis

How did we miss it? What tests are we adding to guard against it in the future?

How was the bug found?

(E.g. customer reported it vs. ad hoc testing)

Test documentation updated?

If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.

jaredpar and others added 30 commits February 27, 2018 14:37
…to-master-vs-deps

Merge dev15.7.x-vs-deps to master-vs-deps
…ntaxNode for the name to create an alias for.
…IMethodBodyOperation and IConstructorBodyOperation nodes

Fixes dotnet#25167
…to-master-vs-deps

Merge dev15.7.x-vs-deps to master-vs-deps
tmeschter and others added 18 commits March 21, 2018 13:28
Merge Roslyn.Test.Utilities.Traits with Microsoft.CodeAnalysis.Test.Utilities.Traits
…to-master-vs-deps

Merge dev15.7.x-vs-deps to master-vs-deps
….7.x-vs-deps

Merge dev15.7.x to dev15.7.x-vs-deps
…to-dev15.7.x-vs-deps

Merge dev15.6.x-vs-deps to dev15.7.x-vs-deps
…to-master-vs-deps

Merge dev15.7.x-vs-deps to master-vs-deps
…to-master-vs-deps

Merge dev15.7.x-vs-deps to master-vs-deps
@JieCarolHu JieCarolHu requested review from a team as code owners March 27, 2018 22:41
@JieCarolHu JieCarolHu force-pushed the quickInfoMergeMasterVsDeps branch from 1326338 to c2c3925 Compare March 27, 2018 22:47
@JieCarolHu
Copy link
Contributor Author

retest this please

@JieCarolHu
Copy link
Contributor Author

retest windows_debug_unit32_prtest please

@JieCarolHu JieCarolHu merged commit bf5bd6f into dotnet:features/quick-info-party Mar 28, 2018
@JieCarolHu JieCarolHu deleted the quickInfoMergeMasterVsDeps branch April 5, 2018 19:26
@JieCarolHu JieCarolHu restored the quickInfoMergeMasterVsDeps branch April 20, 2018 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.