-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick info merge master vs deps #25776
Merged
JieCarolHu
merged 494 commits into
dotnet:features/quick-info-party
from
JieCarolHu:quickInfoMergeMasterVsDeps
Mar 28, 2018
Merged
Quick info merge master vs deps #25776
JieCarolHu
merged 494 commits into
dotnet:features/quick-info-party
from
JieCarolHu:quickInfoMergeMasterVsDeps
Mar 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-deps Merge master to master-vs-deps
…github.com/dotnet/roslyn into merges/dev15.7.x-vs-deps-to-master-vs-deps
…to-master-vs-deps Merge dev15.7.x-vs-deps to master-vs-deps
Merge dev15.7.x to master
…ntaxNode for the name to create an alias for.
Update language feature status
…s-deps Merge master to master-vs-deps
…s-deps Merge master to master-vs-deps
…IMethodBodyOperation and IConstructorBodyOperation nodes Fixes dotnet#25167
Merge dev15.7.x to master
…to-master-vs-deps Merge dev15.7.x-vs-deps to master-vs-deps
…/dev15.7.x-vs-deps-to-master-vs-deps
Rev packages from beta2 to beta3
Merge Roslyn.Test.Utilities.Traits with Microsoft.CodeAnalysis.Test.Utilities.Traits
…to-master-vs-deps Merge dev15.7.x-vs-deps to master-vs-deps
Merge dev15.7.x to master
….7.x-vs-deps Merge dev15.7.x to dev15.7.x-vs-deps
Fixed typo in build error message
…s-deps Merge master to master-vs-deps
…/dev15.7.x-vs-deps-to-master-vs-deps
…to-dev15.7.x-vs-deps Merge dev15.6.x-vs-deps to dev15.7.x-vs-deps
…to-master-vs-deps Merge dev15.7.x-vs-deps to master-vs-deps
…to-master-vs-deps Merge dev15.7.x-vs-deps to master-vs-deps
…s-deps Merge master to master-vs-deps
JieCarolHu
force-pushed
the
quickInfoMergeMasterVsDeps
branch
from
March 27, 2018 22:47
1326338
to
c2c3925
Compare
retest this please |
retest windows_debug_unit32_prtest please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.