Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to master-vs-deps #25156

Merged
merged 20 commits into from
Mar 2, 2018

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into master-vs-deps.

git fetch --all
git checkout merges/master-to-master-vs-deps
git reset --hard upstream/master-vs-deps
git merge upstream/master
# Fix merge conflicts
git commit
git push merges/master-to-master-vs-deps --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

mkrueger and others added 19 commits February 19, 2018 08:47
More renames of Visual Basic Test Helpers to match the counterparts in
the CSharp code
Added member classification support for c#.
…nd add validation for the specified value. (#25046)

This is a follow-up for #24468
…s expected behavior. looks like got messed up while addressing feedback (#25074)
…25035)

* Remove Binder.CheckFeatureAvailability that uses useSiteDiagnostics

* Report missing constructor symbol in the rewriter

* Move unsafe check to binder instead of conversions

* PR Comments
…xplicitly. (#25109)

so, added using to make it explicit
…zer for Workspace Analyzers (#25108)

* fixed issue where object got reused between analyzer

typescript team found a bug where error from different analyzer is leaked to other analyzer.

* added unit test to prevent regression on leaking errors from previous result to next one.

* removed duplicated analyzer I added from some testing.
Refactor PR: Visual Basic Test Helpers 2
Update language feature status
@dotnet-bot dotnet-bot requested review from a team as code owners March 1, 2018 17:57
@Shyam-Gupta
Copy link
Member

@dotnet-bot retest this please

@Shyam-Gupta Shyam-Gupta merged commit 32c360a into master-vs-deps Mar 2, 2018
@Shyam-Gupta Shyam-Gupta deleted the merges/master-to-master-vs-deps branch March 2, 2018 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants