-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to master-vs-deps #25156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More renames of Visual Basic Test Helpers to match the counterparts in the CSharp code
Added member classification support for c#.
…s expected behavior. looks like got messed up while addressing feedback (#25074)
…25035) * Remove Binder.CheckFeatureAvailability that uses useSiteDiagnostics * Report missing constructor symbol in the rewriter * Move unsafe check to binder instead of conversions * PR Comments
…xplicitly. (#25109) so, added using to make it explicit
…zer for Workspace Analyzers (#25108) * fixed issue where object got reused between analyzer typescript team found a bug where error from different analyzer is leaked to other analyzer. * added unit test to prevent regression on leaking errors from previous result to next one. * removed duplicated analyzer I added from some testing.
Refactor PR: Visual Basic Test Helpers 2
Merge dev15.7.x to master
Update language feature status
@dotnet-bot retest this please |
Shyam-Gupta
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into master-vs-deps.
git fetch --all git checkout merges/master-to-master-vs-deps git reset --hard upstream/master-vs-deps git merge upstream/master # Fix merge conflicts git commit git push merges/master-to-master-vs-deps --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.