Merge dev15.7.x to master #25153
Merged
Merge dev15.7.x to master #25153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears this was using `base.Equals(object)` instead of `Equals(UsedNamespaceOrType)` inadvertently, type checking and unboxing the arg just to box again and call the overridden base method.
…orExpressionBodiedProperties
Looks like two PRs had incompatible changes. This cleans it up.
Fix build break
Call the correct (non boxing) Equals method
…diedProperties Support expression bodied properties in "use auto property" analyzer.
Switch to UIAComWrapper for integration test interop
|
@dotnet-bot retest windows_debug_unit64_prtest please |
|
@Shyam-Gupta this PR is ready. Want you to spot check that I merged the right direction. |
|
@jaredpar Thanks for fixing the PR build. Merge looks fine. |
Shyam-Gupta
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from dev15.7.x into master.
git fetch --all git checkout merges/dev15.7.x-to-master git reset --hard upstream/master git merge upstream/dev15.7.x # Fix merge conflicts git commit git push merges/dev15.7.x-to-master --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.