Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BasicChangeSignatureDialog.VerifyCodeRefactoringOffered fails on jenkins #17393

Closed
CyrusNajmabadi opened this issue Feb 26, 2017 · 2 comments
Closed

BasicChangeSignatureDialog.VerifyCodeRefactoringOffered fails on jenkins #17393

CyrusNajmabadi opened this issue Feb 26, 2017 · 2 comments
Assignees
@sharwell
Labels
Area-IDE Bug Disabled Test Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI
Milestone
15.7

Comments

@CyrusNajmabadi
Copy link
Member

No description provided.

@CyrusNajmabadi
Copy link
Member Author

Tagging @dpoeschl

@Pilchie Pilchie mentioned this issue Feb 27, 2017
Closed
@Pilchie Pilchie added Bug Disabled Test Test Test failures in roslyn-CI labels Feb 27, 2017
@Pilchie Pilchie added this to the 2.1 milestone Feb 27, 2017
@Pilchie Pilchie modified the milestones: 15.1, 15.3 Mar 29, 2017
@MattGertz MattGertz modified the milestones: 15.5, 15.3 Jun 30, 2017
@MattGertz
Copy link
Contributor

Mondo escrow triage: test-only, moving out.

@jinujoseph jinujoseph modified the milestones: 15.5, 15.6, Unknown Oct 31, 2017
sharwell added a commit to sharwell/roslyn that referenced this issue Feb 14, 2018
@sharwell
Enable VerifyCodeRefactoringOffered tests
824d7c6 
The underlying requirement that diagnostics be waitable through
FeatureAttribute.DiagnosticService was recently implemented (dotnet#24783),
so these tests should be reliable again.

Fixes dotnet#17393
@sharwell sharwell assigned sharwell and unassigned dpoeschl Feb 14, 2018
@sharwell sharwell modified the milestones: Unknown, 15.7 Feb 14, 2018
@sharwell sharwell mentioned this issue Feb 14, 2018
Merged
@sharwell sharwell added 4 - In Review A fix for the issue is submitted for review. Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Feb 14, 2018
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 1, 2018
@sharwell
Fix deadlock and spin wait thread starvation in integration tests
ad9c632 
Fixes dotnet#17680
Fixes dotnet#21154
Improves dotnet#17393
@sharwell sharwell mentioned this issue Mar 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Bug Disabled Test Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented Test Test failures in roslyn-CI
Projects
None yet
Milestone
15.7
Development

No branches or pull requests
7 participants
@dpoeschl @Pilchie @sharwell @gafter @CyrusNajmabadi @MattGertz @jinujoseph