Revert "Reintroduce FNV hashing" #9768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 23f7752.
f-alizada
approved these changes
Feb 21, 2024
ladipro
approved these changes
Feb 21, 2024
JanKrivanek
deleted the
revert-9721-revert-9520-revert-stablestringhash
branch
maridematte
pushed a commit
to maridematte/msbuild
that referenced
this pull request
Feb 26, 2024
This reverts commit 23f7752.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9721
Fixes #9765
Details
The move of string hashing utilities requires fix of msbuild loading by CDK (https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1937630), which is part of CDK 1.4.2, but not 1.3.10