-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce FNV hashing #9721
Reintroduce FNV hashing #9721
Conversation
FYI @KirillOsenkov - this is using the faster versions of FNV from MSBuildStructuredLog (the source and your meassurements are linked in the code) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should we document this new feature somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Asking out of curiocity: Is there anything additionally that needs to be done in binarylog viewer after this is merged?
Good question. |
This reverts commit 23f7752.
This reverts commit 23f7752.
Fixes: #9519, #7131
Context
Contains changes from:
Usage
Testing
Documentation
Once PR content is agreed I'll create Doc bug + PR to update https://learn.microsoft.com/en-us/visualstudio/msbuild/property-functions?view=vs-2022#msbuild-stablestringhash
We might not possibly document all the supported algos as of now.