Accept skipDocumentsValidation config parameter from near-operation-file-preset

[sachalifs]

#214

Description

In 2019 dotansimha/graphql-code-generator#2143 lead to dotansimha/graphql-code-generator@1559ab6. This resulted in typechecking being disabled for near-operation-file presets.

In 2022 dotansimha/graphql-code-generator#8222 was created in the former presets repository but hasn't been created in this new repository, thanks to @klyve for that PR.

Since that change the ability to toggle this setting was introduced in: dotansimha/graphql-code-generator#6825.

Running the same tests from dotansimha/graphql-code-generator#2143 it should now be possible to remove the default disable of typechecking for near-operation-file preset.

Typechecking is important and should be enabled by default.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related #214

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as
  expected)
• This change requires a documentation update ?

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

• Using the repository shared in the issue https://github.com/klyve/graphql-codegen-preset-test
• Upgrade to "@graphql-codegen/near-operation-file-preset": "^2.5.0" in package.json file and run yarn
• Updated the node_modules/@graphql-codegen/near-operation-file-preset/cjs/index.js with the changes in this PR
• yarn test and see the expected validation errors in the terminal.

Before	After

Test Environment:

• OS: macOS Ventura 13.4
• @graphql-codegen/near-operation-file-preset: 2.5.0 + changes
• NodeJS: v16.20.0

Checklist:

• I have followed the
  CONTRIBUTING doc and the
  style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• [ x I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Further comments

I went with a solution closer to the suggested one in this comment in the original PR.

I think passing undefined should result on the default { skipDuplicateValidation : true } but going with false should use that value but this could be an overkill, please share your thoughts on this..

[changeset-bot]

🦋 Changeset detected

Latest commit: 6877e7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphql-codegen/near-operation-file-preset	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sachalifs]

Hi @charlypoly, I created this PR to take it over from the last comment you left in dotansimha/graphql-code-generator#8222.

Can you please take a look at it? Thank you very much! 🙇

[sachalifs]

Hi @charlypoly I'm wondering if you could take a look at this PR.

Thanks in advance!

[sachalifs]

Hello @saihaj @Urigo @n1ru4l, I'm wondering if you could take a look at this small PR.

Thanks 🙇

[dargmuesli]

Well, this change broke the pipeline. Not sure why not checks ran on this PR. There is no such thing as options.skipDocumentsValidation: https://github.com/dotansimha/graphql-code-generator/blob/9df36440878a4af53d83b1989bb01e12a74642db/packages/utils/plugins-helpers/src/types.ts#L340

@sachalifs how do you think this should be fixed?
@saihaj could you revert this commit for now, so that the other releases are published?