Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique operation names requirement and near-operation-file preset #2143

Closed
vhenzl opened this issue Jul 10, 2019 · 3 comments
Closed

Unique operation names requirement and near-operation-file preset #2143

vhenzl opened this issue Jul 10, 2019 · 3 comments
Labels
plugins waiting-for-release Fixed/resolved, and waiting for the next stable release

Comments

@vhenzl
Copy link
Contributor

vhenzl commented Jul 10, 2019

The generator throws if it encounters duplicated operation names (requested in #720, implemented in #913).

This is perfectly correct if all generated code goes to a single file. However, with near-operation-file preset, duplicated names aren't a problem any longer (unless the duplication would be in the same file). It seems like the validation should be on output level rather than on global level.

I'm still relatively new to GraphQL world so I'm not sure what are the best practices, maybe it's the best to have unique names anyway, but with my current understanding the requirement of unique names across relatively large application seems to be limiting.
@vhenzl vhenzl mentioned this issue Jul 12, 2019
Closed
@dotansimha
Copy link
Owner

You are right, I'll take a look today :)

@dotansimha dotansimha added bug and removed enhancement labels Aug 1, 2019
@dotansimha dotansimha mentioned this issue Aug 1, 2019
Merged
@dotansimha
Copy link
Owner

Fixed in: #2269 , you can try it with the latest alpha 1.4.1-alpha-45ce6b30.65.

@dotansimha dotansimha added the waiting-for-release Fixed/resolved, and waiting for the next stable release label Aug 1, 2019
@dotansimha
Copy link
Owner

Fixed in 1.5.0 🎉

@vasilak vasilak mentioned this issue Nov 5, 2019
Closed
@klyve klyve mentioned this issue Aug 11, 2022
Closed
9 tasks
@sachalifs sachalifs mentioned this issue Aug 8, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugins waiting-for-release Fixed/resolved, and waiting for the next stable release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vhenzl @dotansimha