Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate queries/mutations is not checked #720

Closed
crissi opened this issue Oct 23, 2018 · 1 comment
Closed

Duplicate queries/mutations is not checked #720

crissi opened this issue Oct 23, 2018 · 1 comment
Assignees
@kamilkisiela
Labels
core Related to codegen core/cli waiting-for-release Fixed/resolved, and waiting for the next stable release

Comments

@crissi
Copy link

crissi commented Oct 23, 2018

Is your feature request related to a problem? Please describe.
The problem is that I can mistakenly give two queries the same name and the generated file will therefore have duplicate classes

Describe the solution you'd like
Check if all queries and mutations names are unique and fail with an error message.

Additional context
image

I might be able to help with a solution.
@dotansimha dotansimha added bug core Related to codegen core/cli labels Oct 24, 2018
@dotansimha dotansimha self-assigned this Oct 25, 2018
@dotansimha dotansimha removed their assignment Nov 16, 2018
@kamilkisiela kamilkisiela self-assigned this Nov 22, 2018
@kamilkisiela kamilkisiela mentioned this issue Nov 22, 2018
Merged
@dotansimha dotansimha added the waiting-for-release Fixed/resolved, and waiting for the next stable release label Nov 23, 2018
@dotansimha
Copy link
Owner

Fixed in 0.14.2 🎉

@vhenzl vhenzl mentioned this issue Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kamilkisiela kamilkisiela

Labels
core Related to codegen core/cli waiting-for-release Fixed/resolved, and waiting for the next stable release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crissi @dotansimha @kamilkisiela