Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (msw) add withSuffix param #385

Merged
merged 22 commits into from
Sep 25, 2023
Merged

feat (msw) add withSuffix param #385

merged 22 commits into from
Sep 25, 2023

Conversation

neil585456525
Copy link
Contributor

@neil585456525 neil585456525 commented Aug 9, 2023

Description

Add a withSuffix param to allow user use typescript-msw link feature without forcing to use it with suffix

Related # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Add withSuffix:false in the msw pludin link configuration.

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2023

🦋 Changeset detected

Latest commit: 5ccbb7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-msw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you create a changeset?

@neil585456525
Copy link
Contributor Author

can you create a changeset?

Added, thx for remiding

@saihaj
Copy link
Collaborator

saihaj commented Sep 13, 2023

can you create a changeset?

Added, thx for remiding

can you take a look why tests are failing ?

CleanShot 2023-09-12 at 22 38 16

@neil585456525
Copy link
Contributor Author

#409

@saihaj
Copy link
Collaborator

saihaj commented Sep 25, 2023

hey @neil585456525 can you try rebasing this PR with main?

@saihaj saihaj added the waiting-for-answer Waiting for answer from author label Sep 25, 2023
saihaj and others added 17 commits September 26, 2023 01:58
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: add addTransformResponse to config

* docs: add changeset

* fix: changeset from path to minor

* fix: move subscription block before generation

* fix: prettier issue

---------

Co-authored-by: Dominic <dominic@nomanini.com>
* Revert "Revert "fix(preset/near-operation-file): accept skipDocumentsValidation config parameter. Closes #214 (#383)" (#413)"

This reverts commit 5739a0e.

* fix(preset/near-operation-file): read skipDocumentsValidation from config (#409)

* fix(preset/near-operation-file): add skipDocumentsValidation presetConfig types

* Create brave-bulldogs-explode.md

* fix(preset/near-operation-file): read skipDocumentsValidation from config

* Update brave-bulldogs-explode.md

* Delete .changeset/brave-bulldogs-explode.md

---------

Co-authored-by: Herman Bilous <herman.belous@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fix(graphql-request): return errors in return type when rawRequest is true

* add changeset

* generate examples
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@neil585456525
Copy link
Contributor Author

@saihaj Done

@saihaj saihaj removed the waiting-for-answer Waiting for answer from author label Sep 25, 2023
package.json Outdated Show resolved Hide resolved
@saihaj saihaj merged commit 753efef into dotansimha:main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants