Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[17.06] Completion cherry picks #135

Merged
merged 11 commits into from
Jul 26, 2017
Merged

[17.06] Completion cherry picks #135

merged 11 commits into from
Jul 26, 2017

Conversation

thaJeztah
Copy link
Member

Bash completion fixes:

ZSH completion fixes:

ping @andrewhsu @albers @jphuynh PTAL

albers and others added 11 commits July 25, 2017 02:51
@albers @thaJeztah
Add bash completion for system prune --volumes
f233248 
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 36b572dfdf6bc7b2519f494afe93130e3a8718b5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for build --iidfile
15acd33 
This adds bash completion for moby/moby#32406.

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 1f8720717d58597cb4474e70fa6d534db132229b)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for awslogs multiline log driver options
b7693dd 
This adds bash completion for moby/moby#30891.

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 1d21a3dd7c4ffff80c093c005b910a131e7fc05a)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add metric plugins to bash completion for `plugin ls --filter capabil…
1828a8b 
…ity`

This adds bash completion for moby/moby#32874.

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 2caf425f02363a5894b5790dcde47a11808d23e1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for docker config command family
1c82e26 
This adds bash completion for
- docker/cli#45
- moby/moby#32336

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit c40952b3058db3c6e44bca8c518d888b83878ce5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Add bash completion for secret inspect --pretty
02a80c5 
Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit 211bd55ae736705a48908833a5e10491f613e255)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Refactor alias delegation in bash completion for secret rm|remove
caf6943 
The completion logic should be implemented in the documented subcommands
(ls, rm) and delegated to from the aliases (list, remove).
For the rm|remove pair, this was implemented vice versa.

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit d585e554d5e3a16f424cb3d92d0f7be342b8c7ca)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@albers @thaJeztah
Improve bash completion for service create|update --detach
7fd4d9d 
bash completion usually completes boolean options that default to `true`
with the `=false` suffix because that is the only syntax that really
changes behavior.
For this option, I implemented completion falsely.

Signed-off-by: Harald Albers <github@albersweb.de>
(cherry picked from commit fc0dafbbd11130ac24f8905f697b71e99f32d4e6)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@jphuynh @thaJeztah
Add zsh completion for system prune --volumes
26ace59 
Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
(cherry picked from commit 6b256484ae3cb4da78e6ddad75b8aaf552b9ae60)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@jphuynh @thaJeztah
Update __docker_get_log_options completion
7ee46d7 
Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
(cherry picked from commit d7ade64d29965a686ce7933865d273e84f1ccce1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@jphuynh @thaJeztah
Remove duplicate publish option in docker service create/update compl…
114d979 
…etion

Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
(cherry picked from commit 6c65ba6c0836ed14501cb40ad2d82cdde6fd168d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@jphuynh
Copy link
Contributor

jphuynh commented Jul 25, 2017

LGTM for the zsh part. 👍

@albers
Copy link
Contributor

albers commented Jul 25, 2017

LGTM for the bash completion part - all completions were successfully verified

@thaJeztah
Copy link
Member Author

Thanks both!

ping @andrewhsu

@andrewhsu andrewhsu added this to the 17.06.1 milestone Jul 25, 2017
@seemethere
Copy link
Contributor

Re-kicked windows build, failure was unrelated to the PR

seemethere
seemethere approved these changes Jul 25, 2017
View reviewed changes
Copy link
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass 👍 LGTM

@andrewhsu andrewhsu changed the title [17.06.1] Completion cherry picks [17.06] Completion cherry picks Jul 26, 2017
@thaJeztah
Copy link
Member Author

ping @andrewhsu for merge

@andrewhsu andrewhsu merged commit eb669c3 into docker-archive:17.06 Jul 26, 2017
@thaJeztah thaJeztah deleted the completion-cherry-picks branch July 26, 2017 22:14
docker-jenkins pushed a commit that referenced this pull request Aug 7, 2018
@docker-unir
Merge pull request #135 from jose-bigio/top_level_make
ae672e2 
Merged with https://github.com/seemethere/unir
Upstream-commit: 0b37662
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Feb 22, 2019
@tiborvass
Merge pull request #135 from thaJeztah/18.09_backport_xattr_fix
761df7a 
[18.09 backport] Ignore xattr ENOTSUP errors on copy (fixes #38155)
Upstream-commit: db7a8cb7ba2de79d68ec73c158571319f82ba212
Component: engine
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
@docker-unir
Merge pull request docker-archive#135 from jose-bigio/top_level_make
0b37662 
Merged with https://github.com/seemethere/unir
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seemethere seemethere seemethere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.06.1
Development

Successfully merging this pull request may close these issues.
5 participants
@thaJeztah @jphuynh @albers @seemethere @andrewhsu