Fix bash completion for service create|update --detach|-d
#284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bash completion usually completes boolean options that default to `true` with the `=false` suffix because that is the only syntax that really changes behavior. For this option, I implemented completion falsely. Signed-off-by: Harald Albers <github@albersweb.de>
albers
changed the title
service create|update --detach|-dservice create|update --detach|-d
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 48.74% 48.73% -0.01%
==========================================
Files 173 173
Lines 11750 11750
==========================================
- Hits 5727 5726 -1
- Misses 5661 5662 +1
Partials 362 362 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #250, I overlooked that the default value for this option is
true.I think this I was thrown back into the dark times when such options were reported like (help output from Docker 1.11.2):
Anyway, this PR adapts this completion to the default behavior for boolean options that default to
true:append the
=falsesuffix because that is the only syntax that really changes behavior.