Remove duplicate publish option in docker service create/update #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etion Signed-off-by: Jean-Pierre Huynh <jean-pierre.huynh@ounet.fr>
|
ping @sdurrheimer PTAL |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
+ Coverage 45.79% 45.8% +<.01%
=========================================
Files 193 193
Lines 16069 16069
=========================================
+ Hits 7359 7360 +1
+ Misses 8324 8323 -1
Partials 386 386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publish option was showing twice. The fix has been made to be compliant with docker service create and docker service update
Note: The whole
create_updateoption list is really outdated. I'm planning on doing am update. Would you recommend everything in a single PR or multiple small ones?