Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all uses of -p, --parameter-set with cmsRun #7888

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

kpedro88
Copy link
Contributor

This PR is the CRAB version of cms-sw/cmssw#42798.

It is already unnecessary to use the -p or --parameter-set flag before specifying the config.py file for cmsRun, so this PR can be merged immediately with no change in functionality.

After cms-sw/cmssw#42650 is merged, subsequent CMSSW releases will no longer support the -p, --parameter-set flags; the config.py file will always be provided as a positional argument. (This goes toward better command-line argument support following Python standards.)

@cmsdmwmbot
Copy link

Can one of the admins verify this patch?

@belforte
Copy link
Member

thnaks @kpedro88 I'll take care. Please note that code in test-old is unused. But we'll need to fix documentation as well. I'll do it. But not today

@belforte belforte self-requested a review September 19, 2023 13:56
@belforte belforte self-assigned this Sep 19, 2023
@belforte
Copy link
Member

very good, thanks @kpedro88

@belforte
Copy link
Member

@kpedro88 this is now deployed on crab preprod instance, I have launched basic validation
but it is usable by others as well.
Simply put this in crabConfig.py

config.section_("General")
config.General.instance = 'preprod'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants