Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all uses of -p, --parameter-set with cmsRun #7888

Merged
merged 1 commit into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/CMSRunAnalysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ def StripReport(report):
print(f"==== {applicationName} Execution started at {UTCNow()} ====")
cmd = "stdbuf -oL -eL "
if not options.scriptExe :
cmd += 'cmsRun -p PSet.py -j FrameworkJobReport.xml'
cmd += 'cmsRun -j FrameworkJobReport.xml PSet.py'
else:
# make sure scriptexe is executable
st = os.stat(options.scriptExe)
Expand Down
2 changes: 1 addition & 1 deletion test-old/templates/config/input_files/fake_exit_code.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
set -x
echo "================= CMSRUN starting ===================="
cmsRun -j FrameworkJobReport.xml -p PSet.py
cmsRun -j FrameworkJobReport.xml PSet.py
echo "================= CMSRUN finished ===================="

#Prepare exit codes
Expand Down
2 changes: 1 addition & 1 deletion test-old/templates/config/input_files/simple_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ echo "================= Dumping PSet ===================="
python -c "import PSet; print PSet.process.dumpPython()"

# Ok, let's stop fooling around and execute the job:
cmsRun -j FrameworkJobReport.xml -p PSet.py
cmsRun -j FrameworkJobReport.xml PSet.py

# $@ will point to the all job passed job parameters
echo "I am a simple output for job "$@ > simpleoutput.txt
2 changes: 1 addition & 1 deletion test/testUtils.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
echo "====== arg checking: \$2 = $2" >> My_output.txt
echo "====== arg checking: \$3 = $3" >> My_output.txt

cmsRun -j FrameworkJobReport.xml -p PSet.py
cmsRun -j FrameworkJobReport.xml PSet.py
ExeExit=$?
echo "============ SB CMSRUN finished =================" >> My_output.txt
echo "============ SB CMSRUN exit code was: $ExeExit ==" >> My_output.txt
Expand Down