-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all uses of -p, --parameter-set with cmsRun #42798
Conversation
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42798/36913
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages:
@perrotta, @smuzaffar, @consuegs, @Dr15Jones, @makortel, @nothingface0, @emanueleusai, @mandrenguyen, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
+core (RelVal-INPUT tests timing out is not critical, as the changes are in unit tests and documentation) |
+1 |
+1
|
Ah, great. Thank you @Dr15Jones |
I was planning to update this PR with other unit test changes, but @Dr15Jones makes a good point that this PR could actually be merged standalone. Let's run the standalone tests to make sure. |
test parameters: |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f642c/34801/summary.html Comparison SummarySummary:
|
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
This PR fixes all tests/scripts outside of the core framework for the update proposed in #42650.
PR validation:
scram b runtests
passes with the affected packages checked out.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
see discussion at #42650