Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all uses of -p, --parameter-set with cmsRun #42798

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

kpedro88
Copy link
Contributor

PR description:

This PR fixes all tests/scripts outside of the core framework for the update proposed in #42650.

PR validation:

scram b runtests passes with the affected packages checked out.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

see discussion at #42650

@kpedro88
Copy link
Contributor Author

test parameters:
pull_requests = #42650

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42798/36913

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

  • Calibration/LumiAlCaRecoProducers (alca)
  • CondCore/ESSources (db, alca)
  • CondTools/DT (db)
  • CondTools/Ecal (db)
  • CondTools/RPC (db)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/SiStripMonitorCluster (dqm)
  • DQMServices/FwkIO (dqm)
  • IOPool/Common (core)
  • RecoJets/JetProducers (reconstruction)
  • RecoLuminosity/LumiProducer (reconstruction)
  • Validation/GlobalDigis (dqm)
  • Validation/GlobalHits (dqm)
  • Validation/GlobalRecHits (dqm)
  • Validation/Mixing (dqm)
  • Validation/TrackerHits (dqm)

@perrotta, @smuzaffar, @consuegs, @Dr15Jones, @makortel, @nothingface0, @emanueleusai, @mandrenguyen, @cmsbuild, @jfernan2, @pmandrik, @syuvivida, @saumyaphor4252, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @yslai, @schoef, @argiro, @fioriNTU, @thomreis, @threus, @seemasharmafnal, @venturia, @jdolen, @makortel, @missirol, @barvic, @sroychow, @tocheng, @jdamgov, @nhanvtran, @gkasieczka, @jandrea, @idebruyn, @mmusich, @clelange, @arossi83, @rchatter, @AnnikaStein, @wddgit, @ahinzmann, @wang0jin, @mariadalfonso this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f642c/34782/summary.html
COMMIT: deb0b28
CMSSW: CMSSW_13_3_X_2023-09-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42798/34782/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3348648
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3348620
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+core

(RelVal-INPUT tests timing out is not critical, as the changes are in unit tests and documentation)

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

@perrotta there is no reason to wait for #42650 as the use of -p hasn't been necessary for more than a decade.

@perrotta
Copy link
Contributor

@perrotta there is no reason to wait for #42650 as the use of -p hasn't been necessary for more than a decade.

Ah, great. Thank you @Dr15Jones
Then I wonder why @kpedro88 has put this on hold... In any case, this PR was only tested together with #42650: to unhold it I imagine tests should be also run standalone

@kpedro88
Copy link
Contributor Author

I was planning to update this PR with other unit test changes, but @Dr15Jones makes a good point that this PR could actually be merged standalone. Let's run the standalone tests to make sure.

@kpedro88
Copy link
Contributor Author

test parameters:

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f642c/34801/summary.html
COMMIT: deb0b28
CMSSW: CMSSW_13_3_X_2023-09-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42798/34801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3348648
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3348623
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@kpedro88
Copy link
Contributor Author

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

  • Will merge this as discussed in ORP on 19-Sep

@cmsbuild cmsbuild merged commit aecdf07 into cms-sw:master Sep 19, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants