Fix usage of sys.argv in cmsRun configs

[kpedro88]

PR description:

This PR accounts for two changes from #42650 in non-core packages:

1. When invoking cmsRun config_file.py ..., inside the Python config file, the contents of sys.argv are ["config_file.py",...] (consistent with the result of python3 config_file.py ...). Previously, when using cmsRun, the contents of sys.argv would be ["cmsRun","config_file.py",...].
2. No need to include the -- separator when calling cmsRun config_file.py [args] to pass args to Python.

Among other things, these changes allow removing various kludgey ways of handling the previous non-standard approach to passing arguments to Python. They also mean that index-based access to sys.argv shifts by 1.

PR validation:

Unit tests that were previously failing (#42650 (comment)) now pass.

(Non-unit tested scripts are fixed on a best effort basis.)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Unlikely to be backported, see discussion at #42650.

[kpedro88]

test parameters:
pull_requests = #42650, #42798

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42823/36945

• This PR adds an extra 208KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMOffline/Trigger/test/harvesting_cfg.py modified in PR(s): DeepCore model 2.2.1 #42816
  • File DQMOffline/Trigger/test/testHLTFiltersDQMonitor_cfg.py modified in PR(s): DeepCore model 2.2.1 #42816
  • File IOPool/Input/test/test_old_raw_data_step1_cfg.py modified in PR(s): Improve memory usage in ParameterSet #42742
  • File L1Trigger/L1TGlobal/test/runGlobalFakeInputProducer.py modified in PR(s): DeepCore model 2.2.1 #42816
  • File L1Trigger/L1TGlobal/test/testVectorCode_data.py modified in PR(s): DeepCore model 2.2.1 #42816

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

• Alignment/MuonAlignment (alca)
• CalibPPS/ESProducers (alca)
• CondTools/BTau (db)
• CondTools/CTPPS (db)
• CondTools/SiPixel (db)
• DPGAnalysis/HcalTools (dqm)
• DQM/BeamMonitor (dqm, db)
• DQM/Integration (dqm)
• DQMOffline/Trigger (dqm)
• DQMServices/StreamerIO (dqm)
• DataFormats/Common (core)
• DataFormats/FEDRawData (daq)
• DataFormats/HLTReco (hlt)
• DataFormats/L1TGlobal (l1)
• DataFormats/Scouting (core)
• GeneratorInterface/Core (generators)
• GeneratorInterface/LHEInterface (generators)
• IOPool/Input (core)
• IOPool/Output (core)
• L1Trigger/L1GctAnalyzer (l1)
• L1Trigger/L1TGlobal (l1)
• L1Trigger/L1TMuonOverlapPhase1 (l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
• L1TriggerConfig/GctConfigProducers (l1)
• RecoEgamma/ElectronIdentification (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)
• RecoLocalMuon/GEMCSCSegment (upgrade, reconstruction)
• RecoParticleFlow/Configuration (reconstruction)
• SimTracker/TrackerMaterialAnalysis (simulation)
• Validation/CaloTowers (dqm)
• Validation/RecoTau (dqm)

@SiewYan, @bbilin, @Martin-Grunewald, @alberto-sanchez, @menglu21, @tjavaid, @perrotta, @civanch, @makortel, @cmsbuild, @missirol, @GurpreetSinghChahal, @mandrenguyen, @smorovic, @pmandrik, @smuzaffar, @consuegs, @Dr15Jones, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @syuvivida, @mmusich, @micsucmed, @francescobrivio, @mkirsano, @nothingface0, @emeschi, @srimanob, @saumyaphor4252, @aloeliger, @rvenditti can you please review it and eventually sign? Thanks.
@emilbols, @Ming-Yan, @makortel, @HuguesBrun, @jainshilpi, @abbiendi, @CeliaFernandez, @Martin-Grunewald, @a-kapoor, @Fedespring, @thomreis, @alberto-sanchez, @missirol, @demuller, @threus, @varuns23, @seemasharmafnal, @VourMa, @pakhotin, @mmarionncern, @vargasa, @Senphy, @abdoulline, @andrea21z, @JanFSchulte, @jhgoh, @tvami, @apsallid, @sobhatta, @cericeci, @ferencek, @francescobrivio, @trocino, @lgray, @grzanka, @rociovilar, @Sam-Harper, @barvic, @silviodonato, @youyingli, @fabferro, @GiacomoSguazzoni, @tocheng, @VinInn, @mroguljic, @bellan, @rovere, @hatakeyamak, @mmusich, @eyigitba, @mtosi, @dgulhan, @batinkov, @AlexDeMoor, @watson-ij, @mkirsano, @Prasant1993, @adewit, @AnnikaStein, @valsdav, @wddgit, @JyothsnaKomaragiri, @dkotlins, @afiqaize, @dinyar, @andrzejnovak, @sameasy, @ram1123 this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc6929/34818/summary.html
COMMIT: c9d5d4f
CMSSW: CMSSW_13_3_X_2023-09-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42823/34818/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS
---> test PrimaryVertex had ERRORS
---> test testPVPlotting had ERRORS

Comparison Summary

Summary:

• You potentially added 8 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358044
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358019
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[mmusich]

+hlt

• re-sign

[kpedro88]

@cms-sw/dqm-l2 @cms-sw/generators-l2 @cms-sw/reconstruction-l2 @cms-sw/simulation-l2 please re-sign

[jfernan2]

+1

[kpedro88]

unhold

[kpedro88]

@cms-sw/dqm-l2 @cms-sw/generators-l2 @cms-sw/simulation-l2 please check as soon as possible (to avoid having to update the PR again and then requiring yet another round of signatures)

[antoniovilela]

ping @cms-sw/generators-l2 @cms-sw/dqm-l2 @cms-sw/simulation-l2

[antoniovilela]

urgent

• so this goes before other PRs and together with Improve command-line argument support for Python configs in cmsRun and edm tools #42650

[tjavaid]

+1

[menglu21]

+1

[rappoccio]

+1

Requires co-dependency from #42650 to resolve errors.

[rappoccio]

merge