Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest updates in DQM/TrackingMonitorSource for data/MC comparisons for the Tracking POG #42991

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

dbruschi
Copy link
Contributor

This pull request contains the implementation of the latest distributions and plugins which are used by the Tracking POG for their data/MC comparisons. The main changes are to the StandaloneTrackMonitor plugin: a bug regarding the Z invariant mass and pt distribution has been fixed (they didn't have an impact on the results anyway), the histograms about the error on the IP are now in log scale, for dilepton events the cosphi3d distribution described here: https://indico.cern.ch/event/1312617/contributions/5521545/attachments/2694079/4675527/2023.08.01.misAlignmentPPD.pdf is evaluated.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37164

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dbruschi for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@rvenditti, @antoniovagnerini, @tjavaid, @cmsbuild, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks.
@JanFSchulte, @arossi83, @idebruyn, @jandrea, @mmusich, @VinInn, @sroychow, @threus, @VourMa, @fioriNTU, @mtosi this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Oct 11, 2023

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37165

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42991 was updated. @nothingface0, @cmsbuild, @antoniovagnerini, @tjavaid, @rvenditti, @syuvivida can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38300d/35138/summary.html
COMMIT: cf63d0c
CMSSW: CMSSW_13_3_X_2023-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42991/35138/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38300d/35138/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38300d/35138/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test SiStripDAQ_O2O_test had ERRORS

RelVals-INPUT

  • 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log

Comparison Summary

Summary:

  • You potentially added 38 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Oct 12, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37195

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #42991 was updated. @tjavaid, @antoniovagnerini, @cmsbuild, @rvenditti, @nothingface0, @syuvivida can you please check and sign again.

@tjavaid
Copy link

tjavaid commented Oct 16, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38300d/35203/summary.html
COMMIT: c04633e
CMSSW: CMSSW_13_3_X_2023-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42991/35203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 23 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356889
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 16, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f969e6e into cms-sw:master Oct 16, 2023
11 checks passed
@dbruschi dbruschi deleted the master_dataMC branch October 27, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants