Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable unit test of hltPrintMenuVersions in non-x86-64 builds #42976

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

missirol
Copy link
Contributor

resolves #42975

(Well, "resolves" is a strong word in this case.)

PR description:

This PR restricts the execution of the unit test of hltPrintMenuVersions (added in #42967) to the x86-64 architecture, given that the python module cx_Oracle is not fully working in CMSSW builds with non-x86-64 architecture (e.g. Aarch64 and PowerPC).

The implementation is tentatively copied from other unit tests in CMSSW.

PR validation:

Tested that the unit test is ignored in a recent Aarch64 IB.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

Will be included in #42969, i.e. the backport of #42967.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42976/37150

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @missirol, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2023

please test for el8_aarch64_gcc11

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2023

+hlt

  • unit tests for el8_aarch64_gcc11 have already passed (as expected hltPrintMenuVersions is not executed)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37169c/35115/summary.html
COMMIT: 3de9d90
CMSSW: CMSSW_13_3_X_2023-10-09-2300/el8_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42976/35115/install.sh to create a dev area with all the needed externals and cmssw changes.

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e518466 into cms-sw:master Oct 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test of hltPrintMenuVersions fails in AArch64 and PowerPC IBs
4 participants