Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(stores): document how to handle the Mozilla review process #756

Closed
wants to merge 1 commit into from

Conversation

JalilArfaoui
Copy link
Member

No description provided.

[Developer Hub](https://addons.mozilla.org/en-US/developers/addons)
| account: infrastructure@lmem.net

In order for the Mozilla review to complete successfully, please the following steps :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please the following steps -> please follow these steps

or smthing like that


- Use [SemaphoreCI](https://semaphoreci.com/lmem/extension/) to deploy to `Firefox production`
- [Download](https://github.com/dis-moi/extension/releases) the source code archive of the version you want to deploy to production extension (`Source code (tar.gz)`)
- Create a `buildDisMoi.sh` file on your machine with the following content :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ease the process and prepare at least part of this script ?
Maybe embed a part of it in the package.json or a dedicated script in bin dir.


- Save changes

Note: We plan to remove any SendInBlue direct call from extension soon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know :D

Could you format it as a note please?

>

@lutangar
Copy link
Member

This PR is the response to issue mozilla/addons-server#743

@lutangar lutangar linked an issue Jan 13, 2021 that may be closed by this pull request
@lutangar
Copy link
Member

ping @JalilArfaoui

@lutangar
Copy link
Member

@JalilArfaoui I'm going to take this back since sendinblue is going to be removed.

see mozilla/addons-server#161

However if we want to fully automate the build on Firefox there are still these issues which aren't resolved at mozilla:
This mozilla/addons#6158 is blocking mozilla/sign-addon#409 and thus blocking us.

@lutangar lutangar assigned lutangar and unassigned lutangar and JalilArfaoui Feb 24, 2021
@lutangar
Copy link
Member

@JalilArfaoui be re-reading your doc, I wonder if we can remove the docker requirement, I think I remember an issue with node version...

@lutangar
Copy link
Member

Also when trying to login as infrastructure@lmem.net to the Firefox account as mentionned in the doc I get the following error:

Primary account email required for sign-in

@MaartenLMEM @JalilArfaoui

@lutangar lutangar force-pushed the doc/firefox_addons_review branch from 24b36e6 to 41d5a40 Compare March 3, 2021 17:12
@lutangar lutangar force-pushed the doc/firefox_addons_review branch 2 times, most recently from 602e15c to f4969a7 Compare March 4, 2021 10:15
@lutangar
Copy link
Member

lutangar commented Mar 4, 2021

I'm closing this in favor of mozilla/addons-server#800

@lutangar lutangar closed this Mar 4, 2021
@JalilArfaoui
Copy link
Member Author

@lutangar It’s cool that we can get rid of the ugly .sh part … but I don’t get why this doc PR is moved into a backend PR about posting contributions ?

Let’s update this one instead, no ?

@JalilArfaoui JalilArfaoui reopened this Mar 8, 2021
@lutangar lutangar closed this Mar 9, 2021
@lutangar
Copy link
Member

lutangar commented Mar 9, 2021

@JalilArfaoui this is the PR which removes the SIB token.
We could either rebase this one on mozilla/addons-server#800 or just use mozilla/addons-server#800.

@lutangar lutangar reopened this Mar 9, 2021
@christpet
Copy link
Contributor

@lutangar is this really in staging?

@lutangar
Copy link
Member

Superseded by mozilla/addons-server#800

@lutangar lutangar closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Mozilla review process
3 participants