-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(stores): document how to handle the Mozilla review process #756
Conversation
[Developer Hub](https://addons.mozilla.org/en-US/developers/addons) | ||
| account: infrastructure@lmem.net | ||
|
||
In order for the Mozilla review to complete successfully, please the following steps : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please the following steps -> please follow these steps
or smthing like that
|
||
- Use [SemaphoreCI](https://semaphoreci.com/lmem/extension/) to deploy to `Firefox production` | ||
- [Download](https://github.com/dis-moi/extension/releases) the source code archive of the version you want to deploy to production extension (`Source code (tar.gz)`) | ||
- Create a `buildDisMoi.sh` file on your machine with the following content : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ease the process and prepare at least part of this script ?
Maybe embed a part of it in the package.json
or a dedicated script in bin
dir.
|
||
- Save changes | ||
|
||
Note: We plan to remove any SendInBlue direct call from extension soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know :D
Could you format it as a note please?
>
|
ping @JalilArfaoui |
@JalilArfaoui I'm going to take this back since sendinblue is going to be removed. However if we want to fully automate the build on Firefox there are still these issues which aren't resolved at mozilla: |
@JalilArfaoui be re-reading your doc, I wonder if we can remove the docker requirement, I think I remember an issue with node version... |
Also when trying to login as
|
24b36e6
to
41d5a40
Compare
602e15c
to
f4969a7
Compare
I'm closing this in favor of mozilla/addons-server#800 |
@lutangar It’s cool that we can get rid of the ugly Let’s update this one instead, no ? |
@JalilArfaoui this is the PR which removes the SIB token. |
@lutangar is this really in staging? |
Superseded by mozilla/addons-server#800 |
No description provided.