Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(stores): document how to handle the Mozilla review process #756

Closed
wants to merge 1 commit into from
Closed

doc(stores): document how to handle the Mozilla review process #756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,3 +222,39 @@ extensions.lmem@gmail.com

To generate your own tokens and deploy from your local environment :
https://github.com/DrewML/chrome-webstore-upload/blob/master/How%20to%20generate%20Google%20API%20keys.md

### Firefox Addons

[Developer Hub](https://addons.mozilla.org/en-US/developers/addons)
| account: infrastructure@lmem.net

In order for the Mozilla review to complete successfully, please the following steps :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please the following steps -> please follow these steps

or smthing like that


- Use [SemaphoreCI](https://semaphoreci.com/lmem/extension/) to deploy to `Firefox production`
- [Download](https://github.com/dis-moi/extension/releases) the source code archive of the version you want to deploy to production extension (`Source code (tar.gz)`)
- Create a `buildDisMoi.sh` file on your machine with the following content :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we ease the process and prepare at least part of this script ?
Maybe embed a part of it in the package.json or a dedicated script in bin dir.


```shell script
#!/usr/bin/env bash
echo "SEND_IN_BLUE_TOKEN=SIB_TOKEN" > .env
docker run -v `pwd`:/app -w /app node:10.15.0 yarn install && yarn build:firefox:production
```

where `SIB_TOKEN` is the SendInBlue token

- Add the `buildDisMoi.sh` to the downloaded archive
- Once version is available in [Developer Hub](https://addons.mozilla.org/en-US/developers/addon/dismoi/versions), enter the version form and complete :
- In `Source code`, upload the modified tar.gz archive
- In `Notes for reviewers`, paste :

```
Requirement: Docker

Instructions:
- Extract archive
- Run ./buildDisMoi.sh
```

- Save changes

Note: We plan to remove any SendInBlue direct call from extension soon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know :D

Could you format it as a note please?

>